forked from thredded/thredded
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reporting posts #3
Open
drusepth
wants to merge
19
commits into
master
Choose a base branch
from
feature/report-posts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c02d977
Add basic post reporting functionality
drusepth 09909e7
Limit post reporting to users signed in
drusepth a3d791d
follow standard for post policies
drusepth 4578ebb
Address rubocop concerns
drusepth 3724838
Merge branch 'master' into feature/report-posts
drusepth 8de8dc1
Merge branch 'master' into feature/report-posts
drusepth f3917c8
don't require post preloading when a preloader isn't found
drusepth a558800
don't report? in pms
drusepth 76dad67
Require data-confirm confirmation on report selection
drusepth 20c41ae
Use i18n for confirm message
drusepth a057636
Merge branch 'master' into feature/report-posts
drusepth b9ff1fd
PostView: Also delegate `cache_version`
glebm d8dc158
collection renderer: Use Rails 6 cache methods
glebm 7f0c860
Merge branch 'collection-cache' into feature/report-posts
drusepth b9a3976
Merge branch 'master' into feature/report-posts
drusepth 6ed4027
Merge branch 'master' into feature/report-posts
drusepth 262c55b
Merge branch 'master' into feature/report-posts
drusepth f5200ea
add flagging directly from post dropdown for moderators
drusepth edd58a7
only show moderation actions on public Posts, not PMs
drusepth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,11 @@ def destroy? | |
[email protected]_post_in_topic? && update? | ||
end | ||
|
||
def report? | ||
# Only allow logged-in users to report posts | ||
!(@user.is_a? Thredded::NullUser) | ||
end | ||
|
||
def anonymous? | ||
@user.thredded_anonymous? | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -46,6 +46,10 @@ def can_moderate? | |
@can_moderate ||= @policy.moderate? | ||
end | ||
|
||
def can_report? | ||
@can_report ||= [email protected](:report?) | ||
end | ||
|
||
def quote_url_params | ||
if @post.private_topic_post? | ||
{ post: { quote_private_post_id: @post.id } } | ||
|
@@ -66,6 +70,10 @@ def mark_unread_path | |
Thredded::UrlsHelper.mark_unread_path(@post) | ||
end | ||
|
||
def report_path | ||
Thredded::UrlsHelper.report_post_path(@post) | ||
end | ||
|
||
def destroy_path | ||
Thredded::UrlsHelper.delete_post_path(@post) | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<%= button_to t('thredded.posts.flag'), post.flag_path, | ||
method: :post, | ||
class: 'thredded--post--report thredded--post--dropdown--actions--item', | ||
data: { confirm: I18n.t('thredded.posts.flag_confirm') } | ||
%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<%= button_to t('thredded.posts.report'), post.report_path, | ||
method: :post, | ||
class: 'thredded--post--report thredded--post--dropdown--actions--item', | ||
data: { confirm: I18n.t('thredded.posts.report_confirm') } | ||
%> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not yet sure what the preloaders are for or why we can no longer find them when a post has been reported. This is a hack that needs addressed.