IWF-141: Disable global version search attribute #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -58,6 +59,10 @@ func (p *GlobalVersioner) IsAfterVersionOfTemporal26SDK() bool { | |||
| return p.version >= StartingVersionTemporal26SDK | |||
| } | |||
|
|
|||
| func (p *GlobalVersioner) IsAfterVersionOfNoIwfGlobalVersionSearchAttribute() bool { | |||
There was a problem hiding this comment.
actually, we don't have to strictly use this naming pattern. I think we could just rename the existing one to
IsUsingGlobalVersionSearchAttribute(){
return version >= .. && <= ...;
}
| @@ -58,6 +61,16 @@ func (p *GlobalVersioner) IsAfterVersionOfTemporal26SDK() bool { | |||
| return p.version >= StartingVersionTemporal26SDK | |||
| } | |||
|
|
|||
| func (p *GlobalVersioner) IsAfterVersionOfNoIwfGlobalVersionSearchAttribute() bool { | |||
There was a problem hiding this comment.
Nit: it is not being used so can be removed. Do you put it here intentionally for consistency?
There was a problem hiding this comment.
Yes, I added it for consistency
There was a problem hiding this comment.
Yeah Sounds good. I am fine to keep it
longquanzheng
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issue
Closes #427