feat: blur images with missing or unhelpful alt tags #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cindyli
approved these changes
Sep 10, 2020
|
Thanks for the fix, @greatislander. Blurred images are good warning signs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run lintwithout errorsnpm run startand reviewing affected routesnpm run buildwithout errorsDescription
This PR implements a CSS utility to blur images which have either a missing alt tag or an alt tag beginning with
This image has an empty alt attribute(see #389). Images with alt tags which are present but empty are assumed to be decorative and are unaffected.Steps to test
netlify dev.Expected behavior: Badge images are blurred.
Additional information
Adapted from platform-coop-toolkit/pinecone#230.
Related issues
Not applicable