-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge(?): World coordinate system values #123
Conversation
+1 |
This PR has just been rebased. Do you think we could merge these changes? |
@cmaumet - this looks good. my two worries (not necessary to prevent merging for now) are:
btw @khelm do scanners contain information about orientation of the bore and latitude/longitude of the scanner. |
@satra: thank you for your comments. Regarding your point 2: I am wondering if I liked Would |
@satra: I will check. I know it's been difficult to get from vendors info on their gradient coordinate system, how they define the patient orientation etc, so I don't know if they put it in DICOM or not. Lat/Long would be a surprise. |
+1 to merge |
Thank you for the comments! I will now merge those changes. I have created issue #139 to continue the discussion on the naming and hierarchy of those terms. |
Merge(?): World coordinate system values
Following discussion at #52 with @nicholst, @satra and @jbpoline, a first implementation of the
WorldCoordinateSystem
terms is included in this pull request.The current hierarchy is as follows:
Definitions must be re-worked. In particular, for each
CoordinateSystem
, we would need to specify (as suggested by @satra):