Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Measure test coverage #344

Merged
merged 1 commit into from
May 3, 2023
Merged

Measure test coverage #344

merged 1 commit into from
May 3, 2023

Conversation

jwodder
Copy link
Collaborator

@jwodder jwodder commented May 3, 2023

Part of #325.

@jwodder jwodder added the cleanup label May 3, 2023
@jwodder jwodder mentioned this pull request May 3, 2023
Open
35 tasks
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@47ec0cc). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##             master     #344   +/-   ##
=========================================
  Coverage          ?   33.63%           
=========================================
  Files             ?       50           
  Lines             ?     7053           
  Branches          ?     1781           
=========================================
  Hits              ?     2372           
  Misses            ?     4502           
  Partials          ?      179

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yarikoptic
yarikoptic reviewed May 3, 2023
View reviewed changes
tox.ini
[coverage:paths]
source =
src
.tox/**/site-packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need both src and .tox paths here? i.e. which is one is really in use or really both while running tox testing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of this config setting is to get coverage to treat paths installed under .tox as though they were actually the equivalent paths under src.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, not yet sure how/why that would do it but I will just trust you on this ;)

@jwodder jwodder added the tests Add or improve existing tests label May 3, 2023
@yarikoptic yarikoptic merged commit bd7fff1 into master May 3, 2023
@yarikoptic yarikoptic deleted the coverage branch May 3, 2023 19:29
@github-actions
Copy link

🚀 PR was released in v4.0.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic left review comments

Assignees
No one assigned
Labels
cleanup released This issue/pull request has been released. tests Add or improve existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwodder @codecov-commenter @yarikoptic