Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5061 - Multiple synchronous recommenders only the last one wins #5062

Conversation

reckart
Copy link
Member

@reckart reckart commented Sep 24, 2024

What's in the PR

  • Display score in entity linker recommender if index can provide a score
  • Use the suggestion with the highest score as the canonical one
  • Apply all synchronous recommenders in a single task and make sure they do not overwrite each other

How to test manually

  • See issue

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 34.0 milestone Sep 24, 2024
@reckart reckart self-assigned this Sep 24, 2024
@reckart reckart force-pushed the bugfix/5061-Multiple-synchronous-recommenders-only-the-last-one-wins branch from 71b9571 to 08f2cab Compare September 25, 2024 18:47
- Display score in entity linker recommender if index can provide a score
- Use the suggestion with the highest score as the canonical one
- Apply all synchronous recommenders in a single task and make sure they do not overwrite each other
@reckart reckart force-pushed the bugfix/5061-Multiple-synchronous-recommenders-only-the-last-one-wins branch from 08f2cab to cffc4cb Compare September 25, 2024 19:30
@reckart reckart merged commit dd3581b into release/34.x Sep 26, 2024
3 checks passed
@reckart reckart deleted the bugfix/5061-Multiple-synchronous-recommenders-only-the-last-one-wins branch September 26, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant