Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4901 - Consider document structure when splitting sentences in custom XML formats #4902

Merged
merged 1 commit into from
Jun 25, 2024
Merged

#4901 - Consider document structure when splitting sentences in custom XML formats #4902

merged 1 commit into from
Jun 25, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 25, 2024

What's in the PR

  • Added options to define block elements in XML files which are considered when doing sentence splitting

How to test manually

  • Add new configuration options to custom XML format JSON, e.g.
{
  "name": "TMX (external)",
  "stylesheets": [ 
    "styles.css"
  ],
  "blockElements": [
    "seg"
  ],
  "splitSentencesInBlockElements": false
}

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added the ⭐️ Enhancement New feature or request label Jun 25, 2024
@reckart reckart added this to the 33.1 milestone Jun 25, 2024
@reckart reckart self-assigned this Jun 25, 2024
@reckart
#4901 - Consider document structure when splitting sentences in custo…
5c93e12 
…m XML formats

- Added options to define block elements in XML files which are considered when doing sentence splitting
@reckart reckart force-pushed the feature/4901-Consider-document-structure-when-splitting-sentences-in-custom-XML-formats branch from 599bc46 to 5c93e12 Compare June 25, 2024 05:57
@reckart reckart merged commit f3e4e6d into release/33.x Jun 25, 2024
3 checks passed
@reckart reckart deleted the feature/4901-Consider-document-structure-when-splitting-sentences-in-custom-XML-formats branch June 25, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request
Projects
Kanban
Archived in project
Milestone
33.1
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart