Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4889 - Document sometimes not rendered in by line brat render modes #4890

Merged
merged 4 commits into from
Jun 23, 2024
Merged

#4889 - Document sometimes not rendered in by line brat render modes #4890

merged 4 commits into from
Jun 23, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented Jun 22, 2024

What's in the PR

  • Create a virtual chunk at the end of the viewport if necessary to avoid the brat rendering process crashing later because the end-of-page fragment rel:1-after cannot be assigned to a chunk
  • Fix span clipping in the backend

How to test manually

  • See issue description
  • In general, view documents with (long) spans and relations in brat mode

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

reckart added 2 commits June 21, 2024 23:20
@reckart
#4889 - Document sometimes not rendered in by-line brat render modes
6b8818e 
- Create a virtual chunk at the end of the viewport if necessary to avoid the brat rendering process crashing later because the end-of-page fragment `rel:1-after` cannot be assigned to a chunk
@reckart
#4889 - Document sometimes not rendered in by-line brat render modes
b5285b5 
- Fix handling of virtual chunks for viewport-initial and viewport-final relation anchoring
- Fix span clipping in the backend
@reckart reckart added this to the 33.1 milestone Jun 22, 2024
@reckart reckart self-assigned this Jun 22, 2024
reckart added 2 commits June 22, 2024 20:31
@reckart
#4889 - Document sometimes not rendered in by-line brat render modes
f76792b 
- Fix additional problems with rendering clipped spans
- Do not render zero-width splits of split spans to avoid crashing the brat rendering code
@reckart
#4889 - Document sometimes not rendered in by-line brat render modes
52ab2c1 
- Better destroying of brat annotator
@reckart reckart changed the title Bugfix/4889 document sometimes not rendered in by line brat render modes #4889 - Document sometimes not rendered in by line brat render modes Jun 23, 2024
@reckart reckart merged commit 5f69bc0 into release/33.x Jun 23, 2024
3 checks passed
@reckart reckart deleted the bugfix/4889-Document-sometimes-not-rendered-in-by-line-brat-render-modes branch June 23, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation Module: brat
Projects
Kanban
Archived in project
Milestone
33.1
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart