Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3990 - Layer validation should not consider hidden conditional features #4818

Conversation

reckart
Copy link
Member

@reckart reckart commented May 21, 2024

What's in the PR

  • Skip validation of features hidden due to constraints
  • Reset values of hidden features
  • Modernize code
  • Introduce in-memory cache for constraints so we can efficiently access them when we do not have access to the annotator state

How to test manually
See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 33.0 milestone May 21, 2024
@reckart reckart self-assigned this May 21, 2024
@reckart reckart force-pushed the bugfix/3990-Layer-validation-should-not-consider-hidden-conditional-features branch from 305cb6d to 7fe6038 Compare May 21, 2024 20:28
- Skip validation of features hidden due to constraints
- Reset values of hidden features
- Modernize code
- Introduce in-memory cache for constraints so we can efficiently access them when we do not have access to the annotator state
@reckart reckart force-pushed the bugfix/3990-Layer-validation-should-not-consider-hidden-conditional-features branch from 7fe6038 to 432b5ea Compare May 22, 2024 16:08
@reckart reckart merged commit c26476d into main May 22, 2024
3 checks passed
@reckart reckart deleted the bugfix/3990-Layer-validation-should-not-consider-hidden-conditional-features branch May 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant