Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1319 - Cross-Layer Relations #4811

Merged
merged 1 commit into from
May 19, 2024
Merged

#1319 - Cross-Layer Relations #4811

merged 1 commit into from
May 19, 2024

Conversation

reckart
Copy link
Member

@reckart reckart commented May 19, 2024

What's in the PR

  • Allow creating relations in PDF editor if even if there is a need to show a diambiguation popup asking which relationt to create
  • Allow creating relations in recogito editor if even if there is a need to show a diambiguation popup asking which relationt to create
  • Allow creating relations via annotation sidebar if even if there is a need to show a diambiguation popup asking which relationt to create
  • Remove "Whoops - multiple layers" message from annotation sidebar if a span layer is selected that allows for multiple relation layers

How to test manually

  • Use cross-layer relations in different editors and via the link-to context menu in the annotation sidebar as well as in editors

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 33.0 milestone May 19, 2024
@reckart reckart self-assigned this May 19, 2024
@reckart reckart force-pushed the feature/1319-Cross-Layer-Relations branch 3 times, most recently from a944594 to 5dd608e Compare May 19, 2024 14:27
@reckart
#1319 - Cross-Layer Relations
40d0e43 
- Allow creating relations in PDF editor if even if there is a need to show a diambiguation popup asking which relationt to create
- Allow creating relations in recogito editor if even if there is a need to show a diambiguation popup asking which relationt to create
- Allow creating relations via annotation sidebar if even if there is a need to show a diambiguation popup asking which relationt to create
- Remove "Whoops - multiple layers" message from annotation sidebar if a span layer is selected that allows for multiple relation layers
- Adjust CreateSpanAnnotationHandler to work without calling AnnotationDetailEditorPanel
- Tag bad SSL tests as "slow" because the service is a bit unreliable recently
@reckart reckart force-pushed the feature/1319-Cross-Layer-Relations branch from 5dd608e to 40d0e43 Compare May 19, 2024 15:40
@reckart reckart merged commit eedbd14 into main May 19, 2024
3 checks passed
@reckart reckart deleted the feature/1319-Cross-Layer-Relations branch May 19, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Annotation Module: Apache Annotator Module: PDF editor Module: Recogito
Projects
Kanban
Archived in project
Milestone
33.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart