Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4752 - Suggest entities for linking only if there an empty feature in a target annotation to be linked #4754

Conversation

reckart
Copy link
Member

@reckart reckart commented Apr 21, 2024

What's in the PR

  • Added option to suggest entites only if there is a free target feature
  • Added option to disable synchronous behavior of entity linker
  • Expand entity linker to additional layer configurations
  • No longer require sentences for entity linker to work
  • Added new tests
  • Properly inherit suggestions if a recommender is skipped because a particular run does not include (a)sync recommenders
  • Avoid running synchronous recommenders twice when opening a document

How to test manually

  • Try using the entity linker recommender, e.g. in a wikidata linking project

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 33.0 milestone Apr 21, 2024
@reckart reckart self-assigned this Apr 21, 2024
@reckart reckart force-pushed the feature/4752-Suggest-entities-for-linking-only-if-there-an-empty-feature-in-a-target-annotation-to-be-linked branch from a7ffd77 to ac13eef Compare April 21, 2024 21:38
…n a target annotation to be linked

- Added option to suggest entites only if there is a free target feature
- Added option to disable synchronous behavior of entity linker
- Expand entity linker to additional layer configurations
- No longer require sentences for entity linker to work
- Added new tests
- Properly inherit suggestions if a recommender is skipped because a particular run does not include (a)sync recommenders
- Avoid running synchronous recommenders twice when opening a document
@reckart reckart force-pushed the feature/4752-Suggest-entities-for-linking-only-if-there-an-empty-feature-in-a-target-annotation-to-be-linked branch from ac13eef to 23bf816 Compare April 22, 2024 04:33
@reckart reckart merged commit df321c2 into main Apr 22, 2024
3 checks passed
@reckart reckart deleted the feature/4752-Suggest-entities-for-linking-only-if-there-an-empty-feature-in-a-target-annotation-to-be-linked branch April 22, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant