Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4602 - Project-specific user preferences may be saved without a user #4604

Conversation

reckart
Copy link
Member

@reckart reckart commented Mar 7, 2024

What's in the PR

  • Add non-null constraints to user and project columns in the preferences tables
  • Add null-checks to the Preferences service to be able to catch nulls early

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Add non-null constraints to user and project columns in the preferences tables
- Add null-checks to the Preferences service to be able to catch nulls early
@reckart reckart added 🐛Bug Something isn't working Module: Preferences labels Mar 7, 2024
@reckart reckart added this to the 32.0 milestone Mar 7, 2024
@reckart reckart self-assigned this Mar 7, 2024
…s-may-be-saved-without-a-user

* main:
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file

% Conflicts:
%	inception/inception-preferences/src/main/java/de/tudarmstadt/ukp/inception/preferences/PreferencesServiceImpl.java
@reckart reckart force-pushed the bugfix/4602-Project-specific-user-preferences-may-be-saved-without-a-user branch from d061095 to 8d13bf3 Compare March 7, 2024 09:52
@reckart reckart merged commit 3759b2f into main Mar 7, 2024
2 checks passed
@reckart reckart deleted the bugfix/4602-Project-specific-user-preferences-may-be-saved-without-a-user branch March 7, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Preferences
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant