#4377 - Configure include and exclude patterns for logged events #4490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deprecated exclude events. - Introduced include and exclude patterns. - Including everything (.*) by default, and excluding a predefined set of events by default. - Refactored EventLoggingListener to use the new include and exclude patterns. - Added tests.
- Added missing license header
reckart
force-pushed
the
feature/4377-configure-patterns-for-logged-events
branch
from
796a741 to
0eaa21d
Compare
reckart
requested changes
Feb 2, 2024
...ption/inception-log/src/main/java/de/tudarmstadt/ukp/inception/log/EventLoggingListener.java
Outdated
Show resolved
Hide resolved
...on-log/src/main/java/de/tudarmstadt/ukp/inception/log/config/EventLoggingPropertiesImpl.java
Outdated
Show resolved
Hide resolved
...on-log/src/main/java/de/tudarmstadt/ukp/inception/log/config/EventLoggingPropertiesImpl.java
Outdated
Show resolved
Hide resolved
...on-log/src/main/java/de/tudarmstadt/ukp/inception/log/config/EventLoggingPropertiesImpl.java
Outdated
Show resolved
Hide resolved
...og/src/test/java/de/tudarmstadt/ukp/inception/log/config/EventLoggingPropertiesImplTest.java
Outdated
Show resolved
Hide resolved
- Fixed parameter name.
- Optimized event name logging with pattern caching to avoid repetitive pattern processing.
- Added assertion to check that event not in exclude list.
- Fixed parameter name.
- Moved shouldLogEvent to EventLoggingListener as a package-private method to keep EventLoggingProperties a data class.
- Removed unit test for EventLoggingPropertiesImplTest. - Added unit test for EventLoggingListenerTest to test shouldLogEvent method.
- Added missing license header
- Treat an empty include patterns set as "include all" - Bit of cleaning up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation