Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4414 - Number of new suggestions not displayed correctly #4415

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 28, 2023

What's in the PR

  • Fix aging
  • Pass reconciliation result info into the predictions object
  • Two methods, one for inheriting suggestions, the other for putting new ones
  • Display the number of documents containing new suggestions in the flash message

How to test manually

  • See issue description

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Dec 28, 2023
@reckart reckart added this to the 30.1 milestone Dec 28, 2023
@reckart reckart self-assigned this Dec 28, 2023
@reckart reckart changed the base branch from main to release/30.x December 28, 2023 15:27
- Fix aging
- Pass reconciliation result info into the predictions object
- Two methods, one for inheriting suggestions, the other for putting new ones
@reckart reckart force-pushed the bugfix/4414-Number-of-new-suggestions-not-displayed-correctly branch from 05ba7ab to ed48cd6 Compare December 28, 2023 15:44
@reckart reckart merged commit 66c61b3 into release/30.x Dec 28, 2023
1 check passed
@reckart reckart deleted the bugfix/4414-Number-of-new-suggestions-not-displayed-correctly branch December 28, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant