Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4408 - String Matching Recommender does not evaluate on annotations without label #4409

Merged
merged 1 commit into from
Dec 28, 2023
Merged

#4408 - String Matching Recommender does not evaluate on annotations without label #4409

merged 1 commit into from
Dec 28, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 28, 2023

What's in the PR

  • Added test
  • Fix evaluation when there is no label

How to test manually

  • See issue

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#4408 - String Matching Recommender does not evaluate on annotations …
dc90a65 
…without label

- Added test
- Fix evaluation when there is no label
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Dec 28, 2023
@reckart reckart added this to the 30.1 milestone Dec 28, 2023
@reckart reckart self-assigned this Dec 28, 2023
@reckart reckart merged commit 3b71116 into release/30.x Dec 28, 2023
1 check passed
@reckart reckart deleted the bugfix/4408-String-Matching-Recommender-does-not-evaluate-on-annotations-without-label branch December 28, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
Archived in project
Milestone
30.1
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart