Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2696 - Document-level recommendations #4393

Merged
merged 10 commits into from
Dec 25, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 24, 2023

What's in the PR

  • Move creation of renderers into new suggestion supports
  • Move of extraction code into suggestion supports
  • Change context type for suggestion support from suggestion to recommender
  • Simplify API and tests

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Move creation of renderers into new suggestion supports
* main:
  #4383 - Hide negative scores in annotation sidebar but still sort by it
  #4383 - Hide negative scores in annotation sidebar but still sort by it

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/render/RecommendationRelationRenderer.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/render/RecommendationSpanRenderer.java
- Move classes to other packages
- Started moving extraction logic into the suggestion supports
@reckart reckart added this to the 31.0 milestone Dec 24, 2023
@reckart reckart self-assigned this Dec 24, 2023
@reckart reckart force-pushed the feature/2696-Document-level-recommendations branch from abd5963 to dc56943 Compare December 24, 2023 21:16
- Continue moving extraction logic into the suggestion supports
@reckart reckart force-pushed the feature/2696-Document-level-recommendations branch from dc56943 to a34fcff Compare December 25, 2023 08:44
- Simplify API and tests
- Simplify API and tests
- Towards handling extraction as part of the suggestion supports
- Change context type for suggestion support from suggestion to recommender
- Complete move of extraction code into suggestion supports
@reckart reckart merged commit 5ec948d into main Dec 25, 2023
1 check passed
@reckart reckart deleted the feature/2696-Document-level-recommendations branch December 25, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant