-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2696 - Document-level recommendations #4393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move creation of renderers into new suggestion supports
* main: #4383 - Hide negative scores in annotation sidebar but still sort by it #4383 - Hide negative scores in annotation sidebar but still sort by it % Conflicts: % inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/render/RecommendationRelationRenderer.java % inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/render/RecommendationSpanRenderer.java
- Move classes to other packages
- Started moving extraction logic into the suggestion supports
reckart
force-pushed
the
feature/2696-Document-level-recommendations
branch
from
December 24, 2023 21:16
abd5963
to
dc56943
Compare
- Continue moving extraction logic into the suggestion supports
reckart
force-pushed
the
feature/2696-Document-level-recommendations
branch
from
December 25, 2023 08:44
dc56943
to
a34fcff
Compare
- Simplify API and tests
- Simplify API and tests
- Towards handling extraction as part of the suggestion supports
- Change context type for suggestion support from suggestion to recommender
- Complete move of extraction code into suggestion supports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation