Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4351 - Always introduce wrapper element in Apache and Recogito #4352

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 5, 2023

What's in the PR

  • Always add the wrapper
  • Adjust code for vertical selection highlight and resize handles to calculate their positions relative to the wrapper

How to test manually

  • Try annotating HTML and other XML texts using RecogitoJS and Apache Annotator editor plugins

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Always add the wrapper
- Adjust code for vertical selection highlight and resize handles to calculate their positions relative to the wrapper
@reckart reckart added this to the 30.0 milestone Dec 5, 2023
@reckart reckart self-assigned this Dec 5, 2023
@reckart reckart merged commit 16b505a into release/30.x Dec 5, 2023
@reckart reckart deleted the refactoring/4351-Always-introduce-wrapper-element-in-Apache-and-Recogito branch December 5, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant