Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4316 - Dissolve generic API module #4317

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 19, 2023

What's in the PR

  • Move document-related event classes to document API module
  • Move DocumentImportExportService interface to appropriate module
  • Move TransientAnnotationStateChangedEvent interface to appropriate module
  • Finally dissolve the module
  • Rename module inception-api-schema to inception-schema-api

How to test manually

  • No specific test procedure

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

- Move document-related event classes to document API module
@reckart reckart added this to the 30.0 milestone Nov 19, 2023
@reckart reckart self-assigned this Nov 19, 2023
- Move schema-related event classes to schema API module
- Move DocumentImportExportService interface to appropriate module
- Move TransientAnnotationStateChangedEvent interface to appropriate module
- Finally dissolve the module
- Rename module inception-api-schema to inception-schema-api
@reckart reckart force-pushed the refactoring/4316-Dissolve-generic-API-module branch from 2fce34e to 7dac019 Compare November 20, 2023 21:52
@reckart reckart merged commit b7d928f into main Nov 21, 2023
1 check passed
@reckart reckart deleted the refactoring/4316-Dissolve-generic-API-module branch November 21, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant