Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4305 - New predictions message is shown even if no new predictions were generated #4307

Conversation

reckart
Copy link
Member

@reckart reckart commented Nov 15, 2023

What's in the PR

  • Display new predictions only if new predictions were generated
  • Also "activate" the refresh button only if new predictions were generated

How to test manually

  • E.g. trigger a retraining for a dictionary recommender when nothing has been annotated yet

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

…ere generated

- Display new predictions only if new predictions were generated
- Also "activate" the refresh button only if new predictions were generated
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Nov 15, 2023
@reckart reckart added this to the 30.0 milestone Nov 15, 2023
@reckart reckart self-assigned this Nov 15, 2023
@reckart reckart merged commit 8511453 into main Nov 15, 2023
1 check passed
@reckart reckart deleted the refactoring/4305-New-predictions-message-is-shown-even-if-no-new-predictions-were-generated branch November 15, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant