Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#4252 - Limit number of annotations displayed in annotation sidebar to avoid crash #4255

Merged
merged 1 commit into from
Oct 24, 2023
Merged

#4252 - Limit number of annotations displayed in annotation sidebar to avoid crash #4255

merged 1 commit into from
Oct 24, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 23, 2023 •
edited
Loading

What's in the PR

  • Limiting annotations for the sidebar to 25k - not sure if this still is too many

How to test manually

  • Load the test set from the UD bosque dataset and try viewing the yield of a relation

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#4252 - Limit number of annotations displayed in annotation sidebar t…
cdb9eca 
…o avoid crash

- Limiting annotations for the sidebar to 25k - not sure if this still is too many
@reckart reckart added this to the 30.0 milestone Oct 23, 2023
@reckart reckart self-assigned this Oct 23, 2023
@reckart reckart merged commit 5520bce into main Oct 24, 2023
@reckart reckart deleted the refactoring/4252-Limit-number-of-annotations-displayed-in-annotation-sidebar-to-avoid-crash branch October 24, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
Module: Annotation ⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
30.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart