#4155 - Better annotation suggestion IDs #4156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Defer setting annotation suggestion IDs until they are added to the predictions object - If an extracted suggestion matches an existing one, inherit the existing suggestion (and its ID) instead - Inherit the ID counter across prediction generations - Upgrade to Java 17 (so we can use records)
- Fix issue with suggestion visibility not being handled after previous commit - Improve display of evaluation result in recommendation sidebar - If evaluation is optional due to the threshold score being 0 do still trigger training - Handle a zero-threshold directly in the recommender service instead of in each engine - Remove some deprecated methods - Add generation and age information to suggestions and prediction sets - Using more var everywhere - Using more static loggers
|
Jenkins, can you test this please? |
1 similar comment
|
Jenkins, can you test this please? |
- Configure build to run on Java 17
- Fix bad variable reference in Jenkinsfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation