Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4040 - Ability to store preferences from client-side code #4041

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented May 30, 2023

What's in the PR

  • Added ClientSideUserPreferencesProvider interface that can be implemented by Spring components to permit access to certain preference keys including their validation
  • Added LoadPreferences and SavePreferences calls to the JS API
  • If an annotation has no label, show the layer name in the annotation browser sidebar instead of "No label"
  • Removed unused DiamEditorBase class

How to test manually

  • Change the grouping mode in the annotation browser sidebar
  • Leave page and come back
  • Grouping mode should still be the same

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added this to the 29.0 milestone May 30, 2023
@reckart reckart self-assigned this May 30, 2023
* Added `ClientSideUserPreferencesProvider` interface that can be implemented by Spring components to permit access to certain preference keys including their validation
* Added LoadPreferences and SavePreferences calls to the JS API
* If an annotation has no label, show the layer name in the annotation browser sidebar instead of "No label"
* Removed unused DiamEditorBase class
@reckart reckart force-pushed the feature/4040-Ability-to-store-preferences-from-client-side-code branch 2 times, most recently from c8759de to cab66e3 Compare May 30, 2023 12:41
* Fix dependencies
* Store the other annotation browser sidebar preferences a well
@reckart reckart force-pushed the feature/4040-Ability-to-store-preferences-from-client-side-code branch from cab66e3 to 0f5b49e Compare May 30, 2023 13:11
@reckart reckart merged commit ceb2250 into main May 30, 2023
@reckart reckart deleted the feature/4040-Ability-to-store-preferences-from-client-side-code branch May 30, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant