Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2677 - Make it possible to hide the editor preference menu in the editor #3834

Merged
merged 1 commit into from
Feb 27, 2023
Merged

#2677 - Make it possible to hide the editor preference menu in the editor #3834

merged 1 commit into from
Feb 27, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Feb 27, 2023

What's in the PR

  • Added setting in the annotation project settings to disable access to the preferences dialog
  • Respect that setting when constructing the preferences extension for the annotation page action bar
  • Avoid redirecting to WebSocket endpoint from login page

How to test manually

  • Enable/disable the option allowing access to the preference dialog in the annotation panel of the project settings
  • Visit the annotation page to see if the setting has an effect
  • Visit the curation page to see that the setting has no effect there

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#2677 - Make it possible to hide the editor preference menu in the ed…
8decaad 
…itor

- Added setting in the annotation project settings to disable access to the preferences dialog
- Respect that setting when constructing the preferences extension for the annotation page action bar
- Avoid redirecting to WebSocket endpoint from login page
@reckart reckart added this to the 27.0 milestone Feb 27, 2023
@reckart reckart self-assigned this Feb 27, 2023
@reckart reckart merged commit 55c8b9b into main Feb 27, 2023
@reckart reckart deleted the feature/2677-Make-it-possible-to-hide-the-editor-preference-menu-in-the-editor branch February 27, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Annotation Module: Project Settings
Projects
Kanban
Archived in project
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart