Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3745 - Highlight scrolling target after jump in PDF editor #3746

Merged

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 26, 2023

What's in the PR

  • Display a temporary animated highlight at the target of a scroll-to action to draw the users attention

How to test manually

  • Open a PDF document
  • Create some annotations
  • Open the annotation sidebar
  • Click on the text of an annotation to trigger a jump-to action without a selection
  • See the highlight

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

Demo

Screen.Recording.2023-01-26.at.17.38.59.mp4

- Display a temporary animated highlight at the target of a scroll-to action to draw the users attention
@reckart reckart added this to the 27.0 milestone Jan 26, 2023
@reckart reckart self-assigned this Jan 26, 2023
@reckart reckart merged commit 6b05764 into main Jan 26, 2023
@reckart reckart deleted the feature/3745-Highlight-scrolling-target-after-jump-in-PDF-editor branch January 26, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant