Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3701 - Improve grouped-by-label visuals #3702

Merged
merged 1 commit into from
Jan 8, 2023
Merged

#3701 - Improve grouped-by-label visuals #3702

merged 1 commit into from
Jan 8, 2023

Conversation

reckart
Copy link
Member

@reckart reckart commented Jan 8, 2023

What's in the PR

  • Do not repeat the annotation label for every item since it is already shown in the group heading. Instead just display a layer-colored bubble
  • Show an indicator whether an annotation is a relation or a span
  • Display something like "empty span" for zero-width annotations to avoid the sidebar item collapsing in height
  • Make the group headings stick while scrolling so we always know in which group we are
  • Sort by text instead of position when grouping by label

How to test manually

  • Use annotation sidebar

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3701 - Improve grouped-by-label visuals
c65e531 
- Do not repeat the annotation label for every item since it is already shown in the group heading. Instead just display a layer-colored bubble
- Show an indicator whether an annotation is a relation or a span
- Display something like "empty span" for zero-width annotations to avoid the sidebar item collapsing in height
- Make the group headings stick while scrolling so we always know in which group we are
- Sort by text instead of position when grouping by label
@reckart reckart added this to the 27.0 milestone Jan 8, 2023
@reckart reckart self-assigned this Jan 8, 2023
@reckart reckart merged commit a76a2a5 into main Jan 8, 2023
@reckart reckart deleted the feature/3701-Improve-grouped-by-label-visuals branch January 8, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request Module: Annotation
Projects
Kanban
Archived in project
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart