Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3474 - Tagset export dropdown disappears when selecting format #3620

Merged
merged 3 commits into from
Dec 6, 2022
Merged

#3474 - Tagset export dropdown disappears when selecting format #3620

merged 3 commits into from
Dec 6, 2022

Conversation

reckart
Copy link
Member

@reckart reckart commented Dec 6, 2022

What's in the PR

  • Clicking on a format directly downloads the tagset - selection via a radio-group is no longer necessary
  • Importing a tagset auto-detects the format - choosing a format is no longer necessary
  • Improve layout of various buttons
  • Extract more code from UI layer to service / utils

How to test manually

  • Try exporting and importing tagsets in different formats

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#3474 - Tagset export dropdown disappears when selecting format
b3b4dac 
- Clicking on a format directly downloads the tagset - selection via a radio-group is no longer necessary
- Importing a tagset auto-detects the format - choosing a format is no longer necessary
- Improve layout of various buttons
- Extract more code from UI layer to service / utils
@reckart reckart added 🐛Bug Something isn't working Module: Project Settings labels Dec 6, 2022
@reckart reckart added this to the 27.0 milestone Dec 6, 2022
@reckart reckart self-assigned this Dec 6, 2022
@reckart
Merge branch 'main' into bugfix/3474-Tagset-export-dropdown-disappear…
446be9f 
…s-when-selecting-format

* main:
  #3606 - Support for SAML2 IdPs
  #3606 - Support for SAML2 IdPs
  #3616 - Upgrade dependencies
  #3606 - Support for SAML2 IdPs
  #3606 - Support for SAML2 IdPs
  #3606 - Support for SAML2 IdPs
  #3606 - Support for SAML2 IdPs
@reckart
#3474 - Tagset export dropdown disappears when selecting format
a1c6389 
- Fix dependencies
@reckart reckart merged commit 2d00274 into main Dec 6, 2022
@reckart reckart deleted the bugfix/3474-Tagset-export-dropdown-disappears-when-selecting-format branch December 6, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Project Settings
Projects
Kanban
Archived in project
Milestone
27.0
Development

Successfully merging this pull request may close these issues.
1 participant
@reckart