#1778 - Make tokenization editable #2989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Integrate BratVisualizer into BratSuggestionVisualizer since that was the only place it was used - Display sentences/tokens in the annotator views on the curation page if they are editable - If tokens/sentences are editable, run them through the merge process instead of obtaining them from the template
reckart
added
⭐️ Enhancement
- Make AnnotationPage and CurationPage code more similar - Create editor on CurationPage via the editor registry instead of instantiating it directly
* main: #2987 - Error when pressing "add" when no user is selected
- Make AnnotationPage and CurationPage code more similar - Create editor on CurationPage via the editor registry instead of instantiating it directly
- Remove duplicate NoOpPagingStrategy
- Rearrange rendering code in curation so that there is a better separation between pre-rendering and editor-specific serialization - Reduce reliancy on CAS in serializers
- When sentences are editable the use a line-oriented rendering in the curation view - otherwise a sentence-oriented view.
- Move BratSuggestionVisualizer to other package - Rename AnnotatorSegment to AnnotatorSegmentState
- Pull out curation unit overview into separate class
- Mark VDocument-related classes as serializable
- Slight cleaning up
- Add documentation for editable sentences - Disable changing anchoring mode and overlap mode for sentences / tokens - Disable coloring rules for sentences
- Use a line-oriented editor instead of a sentence-oriented editor while the sentence layer is not read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
ui.sentence-layer-editable=trueAutomatic testing
Documentation