Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1828 - Error in importing projects #1835

Merged
merged 1 commit into from
Oct 27, 2020
Merged

#1828 - Error in importing projects #1835

merged 1 commit into from
Oct 27, 2020

Conversation

reckart
Copy link
Member

@reckart reckart commented Oct 27, 2020 •
edited
Loading

What's in the PR

  • Add explicit type cast to avoid linking to a non-Java-8 version of the flip() method
  • Strictly speaking, this does not fix the import issue (the import issue is fixed by an upstream fix in WebAnno), but it fixes the same problem in the project search.
2020-10-27 08:58:51 ERROR [SYSTEM] [dispatcherServlet] - Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Filter execution threw an exception] with root cause
java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasUtils.decodeFSAddress(MtasUtils.java:63) ~[inception-search-mtas-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasDocumentIndex.lambda$featureValuesAtMatch$8(MtasDocumentIndex.java:818) ~[inception-search-mtas-0.17.0.jar!/:?]
	at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174) ~[?:1.8.0_252]
	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1382) ~[?:1.8.0_252]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:482) ~[?:1.8.0_252]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:472) ~[?:1.8.0_252]
	at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150) ~[?:1.8.0_252]
	at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173) ~[?:1.8.0_252]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:1.8.0_252]
	at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:485) ~[?:1.8.0_252]
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasDocumentIndex.featureValuesAtMatch(MtasDocumentIndex.java:819) ~[inception-search-mtas-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasDocumentIndex.doQuery(MtasDocumentIndex.java:752) ~[inception-search-mtas-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasDocumentIndex._executeQuery(MtasDocumentIndex.java:399) ~[inception-search-mtas-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.index.mtas.MtasDocumentIndex.executeQuery(MtasDocumentIndex.java:362) ~[inception-search-mtas-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.SearchServiceImpl.query(SearchServiceImpl.java:436) ~[inception-search-core-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.search.SearchServiceImpl$$FastClassBySpringCGLIB$$d6146f50.invoke(<generated>) ~[inception-search-core-0.17.0.jar!/:?]
	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) ~[spring-core-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:366) ~[spring-tx-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:118) ~[spring-tx-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691) ~[spring-aop-5.2.6.RELEASE.jar!/:5.2.6.RELEASE]
	at de.tudarmstadt.ukp.inception.search.SearchServiceImpl$$EnhancerBySpringCGLIB$$40b16edc.query(<generated>) ~[inception-search-core-0.17.0.jar!/:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_252]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_252]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_252]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_252]
	at org.apache.wicket.proxy.LazyInitProxyFactory$JdkHandler.invoke(LazyInitProxyFactory.java:521) ~[wicket-ioc-8.8.0.jar!/:8.8.0]
	at com.sun.proxy.$Proxy231.query(Unknown Source) ~[?:?]
	at de.tudarmstadt.ukp.inception.app.ui.search.sidebar.SearchResultsProvider.iterator(SearchResultsProvider.java:87) ~[inception-ui-search-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.app.ui.search.sidebar.SearchResultsProviderWrapper.getAllResults(SearchResultsProviderWrapper.java:156) ~[inception-ui-search-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.app.ui.search.sidebar.SearchResultsProviderWrapper.initializeQuery(SearchResultsProviderWrapper.java:149) ~[inception-ui-search-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.app.ui.search.sidebar.SearchAnnotationSidebar.executeSearchResultsGroupedQuery(SearchAnnotationSidebar.java:456) ~[inception-ui-search-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.inception.app.ui.search.sidebar.SearchAnnotationSidebar.actionSearch(SearchAnnotationSidebar.java:411) ~[inception-ui-search-0.17.0.jar!/:?]
	at de.tudarmstadt.ukp.clarin.webanno.support.lambda.LambdaAjaxButton.action(LambdaAjaxButton.java:75) ~[webanno-support-4.0.0-beta-16.jar!/:?]
	at de.tudarmstadt.ukp.clarin.webanno.support.lambda.LambdaAjaxButton.onSubmit(LambdaAjaxButton.java:58) ~[webanno-support-4.0.0-beta-16.jar!/:?]

How to test manually

  • Compile WebAnno on Java 14
  • Run on Java 8
  • Annotate a lemma with a value
  • Perform a sidebar search with the "grouping feature" enabled on the lemma
  • java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart
#1828 - Error in importing projects
47da008 
- Add explicit type cast to avoid linking to a non-Java-8 version of the flip() method
@reckart reckart added 🐛 Bug Something isn't working Module: Project Search labels Oct 27, 2020
@reckart reckart added this to the 0.17.1 milestone Oct 27, 2020
@reckart reckart self-assigned this Oct 27, 2020
@reckart reckart force-pushed the bugfix/1828-Error-in-importing-projects branch from ae36961 to 47da008 Compare October 27, 2020 07:50
@reckart reckart changed the base branch from master to 0.17.x October 27, 2020 07:50
@ukp-svc-jenkins
Copy link

28% (-4.35%) vs master 32%

@ukp-svc-jenkins
Copy link

28% (-4.35%) vs master 32%

@ukp-svc-jenkins
Copy link

28% (-4.34%) vs master 32%

@reckart reckart merged commit c7dfa73 into 0.17.x Oct 27, 2020
@reckart reckart deleted the bugfix/1828-Error-in-importing-projects branch October 27, 2020 09:31
@ukp-svc-jenkins
Copy link

28% (-4.35%) vs master 32%

jcklie pushed a commit that referenced this pull request Feb 2, 2021
@reckart
#1835 - Use server-side timing API to display server times in browser…
444cf86 
… profiling tab

- Added initial support for sending some server-side timings

Closes #1835
jcklie pushed a commit that referenced this pull request Feb 2, 2021
@reckart
Merge commit 'ae4e61460e5058eac135bbaecbed087ea0d13194'
8480700 
* commit 'ae4e61460e5058eac135bbaecbed087ea0d13194':
  #1472 - Upgrade dependencies (4.0.0)
  #1835 - Use server-side timing API to display server times in browser profiling tab
  #1834 - Fetch built-in type system only once

% Conflicts:
%	pom.xml
%	webanno-api-dao/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/dao/AnnotationSchemaServiceImpl.java
%	webanno-brat/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/annotation/BratAnnotationEditor.java
%	webanno-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/WicketApplicationBase.java
reckart added a commit to waleedabdeen/inception that referenced this pull request Feb 6, 2021
@reckart
Merge branch 'master' into feature/1697-Explicit-UI-for-accepting-rej…
1ebb730 
…ecting-recommendations

* master: (82 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release webanno-4.0.0-beta-19
  inception-project#1472 - Upgrade dependencies (4.0.0)
  inception-project#1835 - Use server-side timing API to display server times in browser profiling tab
  inception-project#1834 - Fetch built-in type system only once
  No issue. Added method to get the data folder for a project.
  inception-project#1831 - When many tags exist the annotations are not saved
  inception-project#1826 Update Java JDK in Admin Guide
  No issue. Changed order of items in enum.
  No issue: Add sort markers back to the tables.
  inception-project#1824 - Update Java version in docker file
  inception-project#1824 - Update Java version in docker file
  No issue: Fix problem when reloading the browser while viewing another users annotations who has just made a change to their annotations.
  inception-project#1822 Annotation disabled for curator - update doc state for curation user as well - check for curation in editable
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release webanno-4.0.0-beta-18
  inception-project#1814 - Format code
  No issue: Fix version
  No issue: Set version back to 4.0.0-SNAPSHOT
  No issue: Set version back to 4.0.0-SNAPSHOT
  ...

% Conflicts:
%	webanno-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/rendering/model/VObject.java
%	webanno-brat/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/render/BratRenderer.java
%	webanno-brat/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/render/model/EntityAttributes.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Project Search
Projects
Kanban
Archived in project
Milestone
0.17.1
Development

Successfully merging this pull request may close these issues.
2 participants
@reckart @ukp-svc-jenkins