Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different types of line breaks #5191

Closed
hunnguye opened this issue Nov 28, 2024 · 2 comments
Closed

Support different types of line breaks #5191

hunnguye opened this issue Nov 28, 2024 · 2 comments
Assignees
@reckart
Labels
⭐️ Enhancement New feature or request
Milestone
34.5

Comments

@hunnguye
Copy link

Is your feature request related to a problem? Please describe.
It appears CR newlines are not suported.

Inception displays following text:
image

But when downloading the text as a txt file and opening it in notepad++ it looks like this:
image

Describe the solution you'd like
Displaying correct newlines might increase user experience and help decreasing cognitive load on annotators.

Additional context
Inception Version 34.3
Editor: brat (wrapping @ 120 chars)
@reckart
Copy link
Member

reckart commented Nov 28, 2024

Which editor mode have you configured? Did you use "brat (line-based)" or "brat (wrap at 120 chars")?

@hunnguye
Copy link
Author

Thanks for responding so quickly!

We are using the "brat (wrapping @ 120 chars)" Editor

@reckart reckart self-assigned this Nov 29, 2024
@reckart reckart added the ⭐️ Enhancement New feature or request label Nov 29, 2024
@reckart reckart changed the title Handling newlines Support different types of line breaks Nov 29, 2024
@reckart reckart added this to Kanban Nov 29, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Nov 29, 2024
@reckart reckart added this to the 34.5 milestone Nov 29, 2024
reckart added a commit that referenced this issue Nov 29, 2024
@reckart
#5191 - Support different types of line breaks
39a4336 
- Enhance line-oriented and wrapping paging strategies with support for additional line break types
- Added tests
reckart added a commit that referenced this issue Nov 30, 2024
@reckart
#5191 - Support different types of line breaks
c69a515 
- Enhance line-oriented and wrapping paging strategies with support for additional line break types
- Added tests
reckart added a commit that referenced this issue Nov 30, 2024
@reckart
#5191 - Support different types of line breaks
25b0622 
- Enhance line-oriented and wrapping paging strategies with support for additional line break types
- Added tests
reckart added a commit that referenced this issue Dec 1, 2024
@reckart
Merge pull request #5193 from inception-project/feature/5191-Support-…
292a2e5 
…different-types-of-line-breaks

#5191 - Support different types of line breaks
@reckart reckart closed this as completed Dec 1, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Dec 1, 2024
reckart added a commit that referenced this issue Dec 1, 2024
@reckart
Merge branch 'release/34.x'
c28ea26 
* release/34.x:
  #5194 - Preferences when opening document in HTML editor
  No issue: Remove mentions of evaluation page in documentation since the page has been removed in v30
  #5191 - Support different types of line breaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⭐️ Enhancement New feature or request
Projects
Kanban
Status: 🍹 Done
Milestone
34.5
Development

No branches or pull requests
2 participants
@reckart @hunnguye