Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional feature option for integer features should not be offered #5098

Closed
lfcc1 opened this issue Oct 28, 2024 · 1 comment
Closed

Conditional feature option for integer features should not be offered #5098

lfcc1 opened this issue Oct 28, 2024 · 1 comment
Assignees
@reckart
Labels
🐛Bug Something isn't working Triage
Milestone
34.2

Comments

@lfcc1
Copy link

lfcc1 commented Oct 28, 2024 •
edited by reckart
Loading

Describe the bug

I created a span feature of type Primitive Integer. I enabled the 'Show only when constraints apply' option for this feature. However, the feature is not hidden in the annotation interface, even though no constraints are set for it. It remains visible when it should be hidden.

To Reproduce

Steps to reproduce the behavior:

  1. create a span feature of type Primitive Integer.
  2. Enable the 'Show only when constraints apply' option for this feature.
  3. Ensure that no constraints are set for this feature.
  4. Open the annotation interface and check if the feature is visible.

Expected behavior

The feature should be hidden in the annotation interface, as no constraints apply.

Screenshots

image

Environment

Version and build ID: 33.0 (2024-06-11 20:43:31, build 8865ebb)
Operating system: Linux
Browser: Edge

Additional context

I have also noticed that if the "Limited" option is checked and saved on a "Primitive: Integer" feature, it cannot be unselected afterwards. -> #5101
@lfcc1 lfcc1 added Triage 🐛Bug Something isn't working labels Oct 28, 2024
@reckart reckart added this to the 34.2 milestone Oct 29, 2024
@reckart reckart added this to Kanban Oct 29, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Oct 29, 2024
@reckart
Copy link
Member

reckart commented Oct 29, 2024

The bug here is probably that the Show only when constraints apply option is available for non-string features. Constraints currently only work for string features that have tagsets.

@reckart reckart self-assigned this Oct 29, 2024
@reckart reckart changed the title Span feature of type 'Primitive Integer' with 'Show only when constraints apply' option enabled does not hide. Conditional feature option for integer features should not be offered Oct 29, 2024
reckart added a commit that referenced this issue Oct 29, 2024
@reckart
#5098 - Conditional feature option for integer features should not be…
d862df3 
… offered

- Do not offer the "Show only when constraints match" option for non-string features
reckart added a commit that referenced this issue Oct 29, 2024
@reckart
Merge pull request #5103 from inception-project/bugfix/5098-Condition…
3a4ab9b 
…al-feature-option-for-integer-features-should-not-be-offered

#5098 - Conditional feature option for integer features should not be offered
@reckart reckart closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Oct 29, 2024
reckart added a commit that referenced this issue Oct 29, 2024
@reckart
Merge branch 'release/34.x'
d31dc51 
* release/34.x:
  No issue: Slightly improve annotation sidebar layout to ensure that no text is shown left of the label badge
  #5106 - Type of lookup feature is display wrong after creation
  #5104 - Agreement measure has wrong name
  #5098 - Conditional feature option for integer features should not be offered
  #5101 - Limited option on integer features cannot be turned off
reckart added a commit that referenced this issue Oct 29, 2024
@reckart
Merge branch 'main' into feature/5099-Better-support-for-auto-merging…
c434200 
…-stacked-annotations-with-link-features

* main:
  No issue: Slightly improve annotation sidebar layout to ensure that no text is shown left of the label badge
  #5106 - Type of lookup feature is display wrong after creation
  #5104 - Agreement measure has wrong name
  #5098 - Conditional feature option for integer features should not be offered
  #5101 - Limited option on integer features cannot be turned off
reckart added a commit that referenced this issue Oct 29, 2024
@reckart
Merge branch 'main' into refactoring/3415-Move-all-configuration-opti…
8ca0415 
…ons-to-Spring-configuration-beans

* main:
  No issue: Slightly improve annotation sidebar layout to ensure that no text is shown left of the label badge
  #5106 - Type of lookup feature is display wrong after creation
  #5104 - Agreement measure has wrong name
  #5098 - Conditional feature option for integer features should not be offered
  #5101 - Limited option on integer features cannot be turned off
  #5094 - Improve curation merge dialog layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Triage
Projects
Kanban
Status: 🍹 Done
Milestone
34.2
Development

No branches or pull requests
2 participants
@reckart @lfcc1