Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relations disappear after merging their target/source #5096

Closed
s2fische opened this issue Oct 23, 2024 · 4 comments
Closed

Relations disappear after merging their target/source #5096

s2fische opened this issue Oct 23, 2024 · 4 comments
Assignees
Labels
🐛Bug Something isn't working Module: Annotation
Milestone

Comments

@s2fische
Copy link

While curating in annotation mode, we found that some relations "vanish" after their target or source points are manually merged (in this case, the one named "Element von"), see video. We expect the relation to continue being displayed/stay selectable after the corresponding target or source are merged.

We're not sure whether the issue is due to the stacked spans/entities because in this case, the entities have different names.

INCEpTION.-.Annotation.-.Google.Chrome.2024-10-22.16-30-25.mp4

Please complete the following information:

  • Version and build ID: 33.7 (2024-09-18 21:04:21, build c156ca2)
  • OS: Windows 10 and 11
  • Browser: Chrome
@reckart
Copy link
Member

reckart commented Nov 1, 2024

Might be related to #5114

@reckart reckart added this to the 34.3 milestone Nov 1, 2024
@reckart reckart self-assigned this Nov 1, 2024
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Nov 1, 2024
@reckart reckart added this to Kanban Nov 1, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Nov 1, 2024
@reckart reckart modified the milestones: 34.3, 34.4 Nov 12, 2024
@reckart
Copy link
Member

reckart commented Nov 13, 2024

I can reproduce the issue. Interestingly, it only happens when the option Show all curatable annotations is turned on. When I turn the option off and merge the endpoint, the relation remains visible.

Good catch!

@reckart
Copy link
Member

reckart commented Nov 13, 2024

There seems to be an additional problem. The relation curation suggestion seems to be only visible if both endpoints are within the current page. It seems that partial rendering of long ranging relations is not yet working in the integrated curation view.

reckart added a commit that referenced this issue Nov 16, 2024
- Fix render logic to ensure we actually use an endpoint that has been rendered in showAll mode
reckart added a commit that referenced this issue Nov 16, 2024
- Fix render logic to ensure we actually use an endpoint that has been rendered in showAll mode
reckart added a commit that referenced this issue Nov 16, 2024
…-disappear-after-merging-their-target-or-source

#5096 - Relations disappear after merging their target/source
reckart added a commit that referenced this issue Nov 16, 2024
* release/34.x:
  #5170 - Extra or missing spaces between span text and following text in annotation sidebar
  #5168 - Relations and links starting or ending beyond the current window are not visible in integrated curation
  #5096 - Relations disappear after merging their target/source

% Conflicts:
%	inception/inception-curation-legacy/src/main/java/de/tudarmstadt/ukp/clarin/webanno/curation/casdiff/CasDiff.java
%	inception/inception-curation-legacy/src/main/java/de/tudarmstadt/ukp/clarin/webanno/curation/casdiff/relation/RelationDiffAdapter.java
%	inception/inception-ui-curation/src/main/java/de/tudarmstadt/ukp/inception/ui/curation/sidebar/render/CurationSidebarRenderer.java
@reckart reckart modified the milestones: 34.4, 34.5 Nov 26, 2024
@reckart reckart closed this as completed Nov 26, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Nov 26, 2024
@reckart
Copy link
Member

reckart commented Nov 26, 2024

@s2fische The issue should be fixed in 34.4 - if you still encounter it after upgrading, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Annotation
Projects
Status: 🍹 Done
Development

No branches or pull requests

2 participants