Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reject relation from relation recommender #5008

Closed
Suremain opened this issue Aug 22, 2024 · 0 comments
Closed

Cannot reject relation from relation recommender #5008

Suremain opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
🐛Bug Something isn't working Module: Recommender
Milestone

Comments

@Suremain
Copy link

Suremain commented Aug 22, 2024

Describe the bug
I can't reject relation suggestion from Relation Recommander

To Reproduce
Steps to reproduce the behavior:
0: Open Inception 33.5

  1. Active String Matcher for relations
  2. Go to a document
  3. Active the suggestion
  4. Go to Annotations view
  5. Click to reject button for one relation suggestion
  6. the error :
java.lang.ClassCastException: class de.tudarmstadt.ukp.inception.recommendation.api.model.RelationSuggestion cannot be cast to class de.tudarmstadt.ukp.inception.recommendation.api.model.SpanSuggestion (de.tudarmstadt.ukp.inception.recommendation.api.model.RelationSuggestion and de.tudarmstadt.ukp.inception.recommendation.api.model.SpanSuggestion are in unnamed module of loader org.springframework.boot.loader.LaunchedURLClassLoader @5fcfe4b2) at 
de.tudarmstadt.ukp.inception.recommendation.api.SuggestionSupport_ImplBase.rejectSuggestion(SuggestionSupport_ImplBase.java:149) at 
de.tudarmstadt.ukp.inception.recommendation.service.RecommendationServiceImpl.rejectSuggestion(RecommendationServiceImpl.java:1764) at 
de.tudarmstadt.ukp.inception.recommendation.service.RecommendationServiceImpl$$FastClassBySpringCGLIB$$7b2c1577.invoke(<generated>) at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218) at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:792) at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163) at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:762) at 
org.springframework.transaction.interceptor.TransactionInterceptor$1.proceedWithInvocation(TransactionInterceptor.java:123) at 
org.springframework.transaction.interceptor.TransactionAspectSupport.invokeWithinTransaction(TransactionAspectSupport.java:388) at 
org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:119) at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186) at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:762) at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:707) at 
de.tudarmstadt.ukp.inception.recommendation.service.RecommendationServiceImpl$$EnhancerBySpringCGLIB$$e0981a7.rejectSuggestion(<generated>) at 
de.tudarmstadt.ukp.inception.recommendation.RecommendationEditorExtension.actionRejectRecommendation(RecommendationEditorExtension.java:248) at 
de.tudarmstadt.ukp.inception.recommendation.RecommendationEditorExtension.handleAction(RecommendationEditorExtension.java:154) at 
de.tudarmstadt.ukp.inception.editor.AnnotationEditorExtensionRegistryImpl.fireAction(AnnotationEditorExtensionRegistryImpl.java:120) at 
de.tudarmstadt.ukp.inception.diam.editor.actions.ExtensionActionHandler.handle(ExtensionActionHandler.java:70) at 
de.tudarmstadt.ukp.inception.diam.editor.actions.ExtensionActionHandler.handle(ExtensionActionHandler.java:34) at
de.tudarmstadt.ukp.inception.diam.editor.DiamAjaxBehavior.call(DiamAjaxBehavior.java:109) at
de.tudarmstadt.ukp.inception.diam.editor.DiamAjaxBehavior.lambda$respond$1(DiamAjaxBehavior.java:101) at
java.base/java.util.Optional.ifPresent(Optional.java:178) at
de.tudarmstadt.ukp.inception.diam.editor.DiamAjaxBehavior.respond(DiamAjaxBehavior.java:101) at
org.apache.wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:630) at
org.apache.wicket.core.request.handler.ListenerRequestHandler.internalInvoke(ListenerRequestHandler.java:300) at
org.apache.wicket.core.request.handler.ListenerRequestHandler.invoke(ListenerRequestHandler.java:274) at
org.apache.wicket.core.request.handler.ListenerRequestHandler.invokeListener(ListenerRequestHandler.java:222) at
org.apache.wicket.core.request.handler.ListenerRequestHandler.respond(ListenerRequestHandler.java:202) at 
org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:910) at 
org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:63) at 
org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:294) at 
org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:255) at 
org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:277) at 
org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:208) at 
org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:307) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.orm.jpa.support.OpenEntityManagerInViewFilter.doFilterInternal(OpenEntityManagerInViewFilter.java:186) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
de.tudarmstadt.ukp.inception.support.logging.LoggingFilter.doFilter(LoggingFilter.java:58) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
de.tudarmstadt.ukp.inception.app.config.InceptionServletContextInitializer$1.doFilterInternal(InceptionServletContextInitializer.java:96) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
de.tudarmstadt.ukp.inception.annotation.storage.OpenCasStorageSessionForRequestFilter.doFilter(OpenCasStorageSessionForRequestFilter.java:51) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:352) at 
org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126) at 
org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:131) at 
org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:85) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:100) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:164) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:63) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.session.ConcurrentSessionFilter.doFilter(ConcurrentSessionFilter.java:151) at 
org.springframework.security.web.session.ConcurrentSessionFilter.doFilter(ConcurrentSessionFilter.java:129) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:107) at 
org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:93) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.header.HeaderWriterFilter.doHeadersAfter(HeaderWriterFilter.java:90) at 
org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:75) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:117) at 
org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:87) at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:62) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.session.DisableEncodeUrlFilter.doFilterInternal(DisableEncodeUrlFilter.java:42) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:361) at 
org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:225) at 
org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:190) at 
org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:354) at 
org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:267) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:96) at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201) at 
org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:117) at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:168) at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:144) at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:168) at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:90) at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:481) at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:130) at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93) at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74) at 
org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:761) at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:346) at 
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:388) at 
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63) at 
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:936) at 
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1791) at 
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52) at 
org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1190) at 
org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:659) at 
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63) at 
java.base/java.lang.Thread.run(Thread.java:1623)

Expected behavior
We can reject relation suggestion in order to simplify the view for annotator.

@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Aug 23, 2024
@reckart reckart changed the title Cannot Reject Relation from Relation Recommander Cannot reject relation from relation recommender Aug 23, 2024
@reckart reckart added this to the 33.6 milestone Sep 1, 2024
@reckart reckart self-assigned this Sep 1, 2024
@reckart reckart added this to Kanban Sep 1, 2024
@github-project-automation github-project-automation bot moved this to 🔖 To do in Kanban Sep 1, 2024
reckart added a commit that referenced this issue Sep 1, 2024
- Fix exception when trying to reject a relation suggestion
reckart added a commit that referenced this issue Sep 1, 2024
…ject-relation-from-relation-recommender

#5008 - Cannot reject relation from relation recommender
@reckart reckart closed this as completed Sep 1, 2024
@github-project-automation github-project-automation bot moved this from 🔖 To do to 🍹 Done in Kanban Sep 1, 2024
reckart added a commit that referenced this issue Sep 1, 2024
* release/33.x:
  #5022 - Upgrade dependencies
  #5008 - Cannot reject relation from relation recommender
reckart added a commit that referenced this issue Sep 7, 2024
* main: (108 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  #5009 - Better handling of stacked annotations with link features in curation
  #5009 - Better handling of stacked annotations with link features in curation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.6
  #5040 - Improve feature form tab navigation
  #5037 - Show fraction of annotators that chose a certain label in curation sidebar mode
  #5035 - NBSPs should not be treated as tokens
  #5031 - ChatGPT recommender fails because format is not a supported parameter
  #5029 - Duplicate lines on the about page
  #5027 - Add more CSP configurations
  #4753 - Entity linker should skip already linked concepts
  #5007 - Lazy details on suggestions for multi-value concept features fail rendering
  #5022 - Upgrade dependencies
  #5008 - Cannot reject relation from relation recommender
  #5019 - SVGs embedded in MHTML files are not rendered
  #5017 - Encoding set in MHTML files is not respected
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Recommender
Projects
Archived in project
Development

No branches or pull requests

2 participants