Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotation can almost be resized despite document being finished #4756

Closed
reckart opened this issue Apr 22, 2024 · 0 comments
Closed

Annotation can almost be resized despite document being finished #4756

reckart opened this issue Apr 22, 2024 · 0 comments
Assignees
@reckart
Labels
🐛 Bug Something isn't working Module: Annotation
Milestone
32.1

Comments

@reckart
Copy link
Member

reckart commented Apr 22, 2024

Describe the bug
Annotation can almost be resized despite document being finished. The resize takes place, but then a message that the document has been finished is still logged. However, the resize remains visible.

To Reproduce
Steps to reproduce the behavior:

  1. Mark a document as finished
  2. Resize an annotation
  3. See that annotation remains resized but there was an error message

Expected behavior
The edit action should be rejected before it is performed, but only before the change is saved.

Please complete the following information:

  • Version and build ID: 32.0
@reckart reckart added 🐛 Bug Something isn't working Module: Annotation labels Apr 22, 2024
@reckart reckart added this to the 32.1 milestone Apr 22, 2024
@reckart reckart self-assigned this Apr 22, 2024
reckart added a commit that referenced this issue Apr 22, 2024
@reckart
#4756 - Annotation can almost be resized despite document being finished
4dcd130 
- Check if page is editable directly when the change request is recieved
reckart added a commit that referenced this issue Apr 23, 2024
@reckart
Merge pull request #4757 from inception-project/bugfix/4756-Annotatio…
c1946d2 
…n-can-almost-be-resized-despite-document-being-finished

#4756 - Annotation can almost be resized despite document being finished
@reckart reckart closed this as completed Apr 23, 2024
reckart added a commit that referenced this issue Apr 23, 2024
@reckart
Merge branch 'release/32.x'
700454e 
* release/32.x:
  No issue: Fix small errors in the Ollama documentation
  #4741 - Linked span in curation-mode not showing
  #4756 - Annotation can almost be resized despite document being finished
  #4751 - Suggestions flicker when Entity Linker recommender is used in combination with other recommenders

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/PredictionTask.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Annotation
Projects
Kanban
Archived in project
Milestone
32.1
Development

No branches or pull requests
1 participant
@reckart