Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizing a span does not update annotations on disk #4618

Closed
reckart opened this issue Mar 11, 2024 · 0 comments
Closed

Resizing a span does not update annotations on disk #4618

reckart opened this issue Mar 11, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Milestone
31.3

Comments

@reckart
Copy link
Member

reckart commented Mar 11, 2024

Describe the bug
When a span is resized, this does not trigger a save of the annotations. So unless another action that triggers a save happens in a timely manner, the resize is not persisted.

To Reproduce
Steps to reproduce the behavior:

  1. In the text This is a John Smith., annotate John as a Named Entity
  2. Search for [Named_entity="John"] in the search sidebar
  3. Resize the entity to John Smith
  4. Re-run the search
  5. Note that it still shows the old results and not the updated search results not including the John Smith entity.

Expected behavior
Resizing the span should update the annotations on disk as well as the index

Please complete the following information:

  • Version and build ID: 31.2
@reckart reckart added 🐛Bug Something isn't working Module: Project Search labels Mar 11, 2024
@reckart reckart added this to the 31.3 milestone Mar 11, 2024
@reckart reckart self-assigned this Mar 11, 2024
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
#4618 - Resizing a span does not update annotations on disk
81b202b 
- Save editor CAS after a resize action
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
#4618 - Resizing a span does not update annotations on disk
9120271 
- Save editor CAS after a resize action
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge pull request #4619 from inception-project/bugfix/4618-Resizing-…
c2a7980 
…a-span-does-not-update-annotations-on-disk

#4618 - Resizing a span does not update annotations on disk
@reckart reckart closed this as completed Mar 11, 2024
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'release/31.x'
d3db389 
* release/31.x:
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk

% Conflicts:
%	inception/inception-schema-api/src/main/java/de/tudarmstadt/ukp/inception/schema/api/AnnotationSchemaService.java
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
e5112b4 
* main: (39 commits)
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk
  #4616 - Option to disable displaying suggestions in sidebar curation mode
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  No issue: Try to get build work on Windows
  #4610 - Annotations are misaligned when PDF pages vary in dimensions
  #4611 - Run the three SPARQL queries in the concept linker in parallel
  No issue: Added gitattributes file
  No issue: Enable matrix build
  #4557 - Bulk process page should not show processes from other projects
  #4596 - Ability to temporarily suspend recommenders
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file
  #4583 - Ability to configure layer visibility via a sidebar
  Remove <Proxy> directive as it shouldn't be necessary
  ...

% Conflicts:
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventFooterPanel.java
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	inception/inception-websocket/pom.xml
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
88a3e47 
* main: (39 commits)
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk
  #4616 - Option to disable displaying suggestions in sidebar curation mode
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  No issue: Try to get build work on Windows
  #4610 - Annotations are misaligned when PDF pages vary in dimensions
  #4611 - Run the three SPARQL queries in the concept linker in parallel
  No issue: Added gitattributes file
  No issue: Enable matrix build
  #4557 - Bulk process page should not show processes from other projects
  #4596 - Ability to temporarily suspend recommenders
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file
  #4583 - Ability to configure layer visibility via a sidebar
  Remove <Proxy> directive as it shouldn't be necessary
  ...

% Conflicts:
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventFooterPanel.java
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	inception/inception-websocket/pom.xml
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
74431b7 
* main: (39 commits)
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk
  #4616 - Option to disable displaying suggestions in sidebar curation mode
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  No issue: Try to get build work on Windows
  #4610 - Annotations are misaligned when PDF pages vary in dimensions
  #4611 - Run the three SPARQL queries in the concept linker in parallel
  No issue: Added gitattributes file
  No issue: Enable matrix build
  #4557 - Bulk process page should not show processes from other projects
  #4596 - Ability to temporarily suspend recommenders
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file
  #4583 - Ability to configure layer visibility via a sidebar
  Remove <Proxy> directive as it shouldn't be necessary
  ...

% Conflicts:
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventFooterPanel.java
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	inception/inception-websocket/pom.xml
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
5007693 
* main: (39 commits)
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk
  #4616 - Option to disable displaying suggestions in sidebar curation mode
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  No issue: Try to get build work on Windows
  #4610 - Annotations are misaligned when PDF pages vary in dimensions
  #4611 - Run the three SPARQL queries in the concept linker in parallel
  No issue: Added gitattributes file
  No issue: Enable matrix build
  #4557 - Bulk process page should not show processes from other projects
  #4596 - Ability to temporarily suspend recommenders
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file
  #4583 - Ability to configure layer visibility via a sidebar
  Remove <Proxy> directive as it shouldn't be necessary
  ...

% Conflicts:
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventFooterPanel.java
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	inception/inception-websocket/pom.xml
reckart added a commit that referenced this issue Mar 11, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
7a245e1 
* main: (39 commits)
  No issue: Try to get build work on Windows
  No issue: Added gitattributes file
  #4618 - Resizing a span does not update annotations on disk
  #4616 - Option to disable displaying suggestions in sidebar curation mode
  #4554 - Allow displaying comments from annotators on hover when curating using curation sidebar on the annotation page
  No issue: Try to get build work on Windows
  #4610 - Annotations are misaligned when PDF pages vary in dimensions
  #4611 - Run the three SPARQL queries in the concept linker in parallel
  No issue: Added gitattributes file
  No issue: Enable matrix build
  #4557 - Bulk process page should not show processes from other projects
  #4596 - Ability to temporarily suspend recommenders
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4603 - Bulk actions in search sidebar should not be greyed-out when in sidebar curation mode
  #4602 - Project-specific user preferences may be saved without a user
  #4600 - Error when exporting project during preference phase
  No issue: Fix example CSS file for custom XML format which was actually an SCSS file
  #4583 - Ability to configure layer visibility via a sidebar
  Remove <Proxy> directive as it shouldn't be necessary
  ...

% Conflicts:
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-kb/src/test/java/de/tudarmstadt/ukp/inception/kb/FullTextIndexUpgradeTest.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/footer/RecommendationEventFooterPanel.java
%	inception/inception-ui-scheduling/src/main/java/de/tudarmstadt/ukp/inception/ui/scheduling/TaskMonitorPanel.java
%	inception/inception-websocket/pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Archived in project
Milestone
31.3
Development

No branches or pull requests
1 participant
@reckart