-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotations are misaligned when PDF pages vary in dimensions #4587
Comments
- Adjustment has to be made not only if first page is larger but also if first page is smaller than subsequent pages
…ns-are-misaligned-when-PDF-pages-vary-in-dimensions #4587 - Annotations are misaligned when PDF pages vary in dimensions
I had fixed this some time ago for the case that the first page is wider than the others - but in your case, it is just the opposite. Should work now. |
Screen.Recording.2024-03-04.at.19.35.35.mp4 |
Now that you mention it, I tried one like that too. There's this effect that the annotations shift initially but zoom in/out fixes them: Screen.Recording.2024-03-04.at.21.08.31.mp4That is not so bad and I also notice the pages are actually clipped a little (separate issue?) |
@tpluscode do you have a public link to that PDF? |
I confirm that the Mercedes PDF now behaves correctly. Thank you, The City Angel above is still broken though. Pages clipped and annotations on the 2nd page shift back and forth |
@tpluscode The City Angel should work fine with #4613 |
Regarding clipping - that's probably an issue of PDF.js itself. Maybe try opening the PDF in Mozilla which uses PDF.js as its native PDF viewer to check (although INCEpTION likely uses an older version than current Mozilla versions). |
Super. Thank you so much for your awesome work on this project! |
If by any chance you hear that the AllegoGraph version with the path query fix comes out (8.1.1 I believe), would be great if you could briefly ping me. |
That PDF looks good in Firefox 123 🤷
Will comment on that issue or PR as soon as I know. |
Describe the bug
I have PDFs where some pages are merged. Sometimes they are fold outs where 4 or more pages of the original document are a single page in PDF
To Reproduce
Steps to reproduce the behavior:
The degree to which the annotations are off appears to change with zoom level
Screenshots
INCEpTION.-.Annotation.mp4
Please complete the following information:
The text was updated successfully, but these errors were encountered: