Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow knowledge-base lookups on relation layers #4428

Closed
reckart opened this issue Jan 5, 2024 · 0 comments
Closed

Slow knowledge-base lookups on relation layers #4428

reckart opened this issue Jan 5, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation Module: Entity Linking Module: Knowledge Base
Milestone
30.2

Comments

@reckart
Copy link
Member

reckart commented Jan 5, 2024

Describe the bug
When a concept feature is added to a relation layer, the auto-completion for concepts in the annotation detail editor is terribly slow.

To Reproduce
Steps to reproduce the behavior:

  1. Create a relation layer with a concept feature.
  2. Import a non-trivial ontology like e.g. HPO (https://hpo.jax.org)
  3. Try filling in the concept feature on a relation in the annotation editor
  4. Note that lookup is very slow and may even abort with a Whoops page

Expected behavior
It should not be slower than if the feature were on a span layer.

Please complete the following information:

  • Version and build ID: 30.1
@reckart reckart added this to the 30.2 milestone Jan 5, 2024
@reckart reckart self-assigned this Jan 5, 2024
reckart added a commit that referenced this issue Jan 5, 2024
@reckart
#4428 - Slow knowledge-base lookups on relation layers
736750c 
- Improve translation of query terms into suitable regular expression
- Log slow queries at debug level
- Better generation of query terms from mention in the concepf feature editor
reckart added a commit that referenced this issue Jan 5, 2024
@reckart
#4428 - Slow knowledge-base lookups on relation layers
c3c35a0 
- Improve translation of query terms into suitable regular expression
- Log slow queries at debug level
- Better generation of query terms from mention in the concepf feature editor
reckart added a commit that referenced this issue Jan 5, 2024
@reckart
#4428 - Slow knowledge-base lookups on relation layers
e3481a0 
- Small layout fix in the concept feature traits editor
- Improve documentation for the meaning of root concepts
reckart added a commit that referenced this issue Jan 5, 2024
@reckart
#4428 - Slow knowledge-base lookups on relation layers
b131f6c 
- Small layout fix in the concept feature traits editor
- Improve documentation for the meaning of root concepts
reckart added a commit that referenced this issue Jan 5, 2024
@reckart
Merge pull request #4429 from inception-project/bugfix/4428-Slow-know…
6377788 
…ledge-base-lookups-on-relation-layers

#4428 - Slow knowledge-base lookups on relation layers
@reckart reckart closed this as completed Jan 5, 2024
reckart added a commit that referenced this issue Jan 6, 2024
@reckart
Merge branch 'release/30.x'
e396903 
* release/30.x:
  Update maven.yml
  No issue. Added GH actions file
  #4428 - Slow knowledge-base lookups on relation layers
  #4428 - Slow knowledge-base lookups on relation layers
  #4428 - Slow knowledge-base lookups on relation layers

% Conflicts:
%	.github/workflows/maven.yml
reckart added a commit that referenced this issue Jan 24, 2024
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
eb2bd66 
* main: (53 commits)
  #4448 - Error when trying to index boolean feature values when CAS has not upgraded yet
  #4436 - Change default dynamic workload annotator number to uneven
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.3
  No issue: Try fixing test by releasing latch only after materializing result
  #4444 - Make authentication settings more prominent in admin manual
  #4442 - Option to allow spaces in usernames
  #4439 - Logout may sometimes be incomplete
  #4438 - Buffer server side timing headers
  #4434 - Ability to apply a recommender to all documents in a project
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.2
  #2696 - Document-level recommendations
  No issue. Fix style.
  No issue. Remove unused dependency
  #4430 -Highlight rows may get merged in PDF editor at high scale factors
  Update maven.yml
  No issue. Added GH actions file
  #4428 - Slow knowledge-base lookups on relation layers
  #4428 - Slow knowledge-base lookups on relation layers
  ...

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/SpringAuthenticatedWebSession.java
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation Module: Entity Linking Module: Knowledge Base
Projects
Kanban
Archived in project
Milestone
30.2
Development

No branches or pull requests
1 participant
@reckart