Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some suggestions are not shown right away #4404

Closed
reckart opened this issue Dec 27, 2023 · 0 comments
Closed

Some suggestions are not shown right away #4404

reckart opened this issue Dec 27, 2023 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Recommender
Milestone
30.1

Comments

@reckart
Copy link
Member

reckart commented Dec 27, 2023

Describe the bug
Freshly created suggestions may not be shown due to a bug in the reconciliation code gobbles up all freshly created suggestions but one.

Expected behavior
The reconciliation code should not push all freshly created suggestions into a set which mainly relies on the suggestion ID since all fresh suggestions have the same ID of -1.

Please complete the following information:

  • Version and build ID: 30.0
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Dec 27, 2023
@reckart reckart added this to the 30.1 milestone Dec 27, 2023
@reckart reckart self-assigned this Dec 27, 2023
reckart added a commit that referenced this issue Dec 27, 2023
@reckart
#4404 - Some suggestions are not shown right away
6c90f4f 
- Collect fresh suggestions in a list and only merge them with the actual reconciled suggestions shortly before returning the results
reckart added a commit that referenced this issue Dec 27, 2023
@reckart
Merge pull request #4405 from inception-project/bugfix/4404-Some-sugg…
a0b5697 
…estions-are-not-shown-right-away

#4404 - Some suggestions are not shown right away
@reckart reckart closed this as completed Dec 27, 2023
reckart added a commit that referenced this issue Dec 27, 2023
@reckart
Merge branch 'release/30.x' into bugfix/4402-Some-suggestions-are-not…
e0568fb 
…-hidden-even-though-they-cannot-be-accepted

* release/30.x:
  #4404 - Some suggestions are not shown right away

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
reckart added a commit that referenced this issue Dec 27, 2023
@reckart
Merge branch 'release/30.x'
1a23df2 
* release/30.x:
  #4402 - Some suggestions are not hidden even though they cannot be accepted
  #4406 - Useless "not in tagset" message on suggestions without a label
  #4406 - Useless "not in tagset" message on suggestions without a label
  #4404 - Some suggestions are not shown right away

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/RecommendationEditorExtension.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
reckart added a commit that referenced this issue Dec 30, 2023
@reckart
Merge branch 'main' into feature/4399-Allow-OpenNLP-Multi-Token-Seque…
b8f2b0a 
…nce-Classifier-to-work-for-cross-sentence-layers

* main:
  #4402 - Some suggestions are not hidden even though they cannot be accepted
  #4406 - Useless "not in tagset" message on suggestions without a label
  #4406 - Useless "not in tagset" message on suggestions without a label
  #4404 - Some suggestions are not shown right away
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
Archived in project
Milestone
30.1
Development

No branches or pull requests
1 participant
@reckart