Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize packages #4321

Closed
reckart opened this issue Nov 24, 2023 · 0 comments
Closed

Organize packages #4321

reckart opened this issue Nov 24, 2023 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Nov 24, 2023

Describe the refactoring action
Organize packages.

Expected benefit
There is quite a bit of code that is not in the package (or module) where it probably should be.
@reckart reckart added this to the 30.0 milestone Nov 24, 2023
@reckart reckart self-assigned this Nov 24, 2023
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
fea09df 
- Moved bootstrap stuff into bootstrap module
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
ac2a057 
- Consolidated Kendo stuff in support package
- Moved JQuery stuff to support package
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
25e3dfd 
- Consolidated io support package
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
bc9653b 
- Consolidated spring support package
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
0e1a0f4 
- Consolidated xml support package
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
77359b4 
- Moving classes out of top-level support package into more appropriate subpackages
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
0b98a8d 
- Moving classes out of top-level support package into more appropriate subpackages
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
14b3a31 
- Rename base package in support module
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
cbc6310 
- Rename inception-bootstrap to inception-support-bootstrap
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
#4321 - Organize packages
4467de5 
- Organize imports
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
Merge pull request #4322 from inception-project/refactoring/4321-Orga…
37c01ef 
…nize-packages

#4321 - Organize packages
@reckart reckart closed this as completed Nov 24, 2023
reckart added a commit that referenced this issue Nov 24, 2023
@reckart
Merge branch 'release/30.x'
f57d2e6 
* release/30.x:
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages

% Conflicts:
%	inception/inception-bom/pom.xml
reckart added a commit that referenced this issue Nov 25, 2023
@reckart
Merge branch 'main' into feature/4292-ollama-based-recommender
6f48e52 
* main:
  #34 - Update dependencies
  #4150 - Upgrade dependencies
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  #4229 - Better project template selection
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  No issue: Set version to 31.0-SNAPSHOT

% Conflicts:
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
reckart added a commit that referenced this issue Nov 25, 2023
@reckart
Merge branch 'main' into feature/3411-Resize-sidebars-using-mouse
2037dc2 
* main: (91 commits)
  #34 - Update dependencies
  #4150 - Upgrade dependencies
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  #4229 - Better project template selection
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  No issue. Fix test.
  No issue: Set version to 31.0-SNAPSHOT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.9
  ...

% Conflicts:
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPage.java
reckart added a commit that referenced this issue Nov 25, 2023
@reckart
Merge branch 'main' into refactoring/Upgrade-to-Spring-Boot-3
6ef2a5d 
* main: (53 commits)
  #34 - Update dependencies
  #4150 - Upgrade dependencies
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  #4321 - Organize packages
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  #4229 - Better project template selection
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.0-rc-1
  No issue. Fix test.
  No issue: Set version to 31.0-SNAPSHOT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.9
  ...

% Conflicts:
%	inception/inception-api-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/api/annotation/page/AnnotationPageBase.java
%	inception/inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/app/config/InceptionServletContextInitializer.java
%	inception/inception-brat-editor/src/main/java/de/tudarmstadt/ukp/clarin/webanno/brat/schema/BratSchemaGeneratorImpl.java
%	inception/inception-curation/src/main/java/de/tudarmstadt/ukp/inception/curation/config/CurationDocumentServiceAutoConfiguration.java
%	inception/inception-curation/src/main/java/de/tudarmstadt/ukp/inception/curation/config/CurationServiceAutoConfiguration.java
%	inception/inception-curation/src/main/java/de/tudarmstadt/ukp/inception/curation/service/CurationDocumentServiceImpl.java
%	inception/inception-dependencies/pom.xml
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/editor/actions/EditorAjaxRequestHandler.java
%	inception/inception-diam/src/main/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController.java
%	inception/inception-diam/src/test/java/de/tudarmstadt/ukp/inception/diam/service/DiamWebsocketController_ViewportRoutingTest.java
%	inception/inception-documents/src/main/java/de/tudarmstadt/ukp/inception/documents/DocumentAccessImpl.java
%	inception/inception-documents/src/main/java/de/tudarmstadt/ukp/inception/documents/config/DocumentServiceAutoConfiguration.java
%	inception/inception-documents/src/test/java/de/tudarmstadt/ukp/inception/documents/DocumentServiceImplConcurrencyTest.java
%	inception/inception-external-editor/src/main/java/de/tudarmstadt/ukp/inception/externaleditor/ExternalAnnotationEditorBase.java
%	inception/inception-external-editor/src/main/java/de/tudarmstadt/ukp/inception/externaleditor/xhtml/XHtmlXmlDocumentViewControllerImpl.java
%	inception/inception-external-editor/src/main/java/de/tudarmstadt/ukp/inception/externaleditor/xml/XmlDocumentViewControllerImpl.java
%	inception/inception-imls-stringmatch/src/test/java/de/tudarmstadt/ukp/inception/recommendation/imls/stringmatch/span/gazeteer/GazeteerServiceImplTest.java
%	inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/KnowledgeBaseServiceImpl.java
%	inception/inception-kb/src/main/java/de/tudarmstadt/ukp/inception/kb/config/KnowledgeBaseServiceAutoConfiguration.java
%	inception/inception-model-export/src/main/java/de/tudarmstadt/ukp/clarin/webanno/export/model/ExportedProject.java
%	inception/inception-pdf-editor/src/main/java/de/tudarmstadt/ukp/inception/pdfeditor/PdfAnnotationEditor.java
%	inception/inception-pdf-editor2/src/main/java/de/tudarmstadt/ukp/inception/pdfeditor2/PdfAnnotationEditor.java
%	inception/inception-pdf-editor2/src/main/java/de/tudarmstadt/ukp/inception/pdfeditor2/view/pdfjs/PdfJsViewerPage.java
%	inception/inception-preferences/src/main/java/de/tudarmstadt/ukp/inception/preferences/PreferencesServiceImpl.java
%	inception/inception-project-export/src/main/java/de/tudarmstadt/ukp/inception/project/export/task/ProjectExportTask_ImplBase.java
%	inception/inception-project-export/src/test/java/de/tudarmstadt/ukp/inception/project/export/controller/ExportServiceControllerImplTest.java
%	inception/inception-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/project/ProjectAccessImpl.java
%	inception/inception-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/project/ProjectPermissionExtension.java
%	inception/inception-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/project/ProjectServiceImpl.java
%	inception/inception-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/project/config/ProjectServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/config/RecommenderServiceAutoConfiguration.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/service/RecommendationServiceImpl.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/NonTrainableRecommenderActivationTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/SelectionTask.java
%	inception/inception-recommendation/src/main/java/de/tudarmstadt/ukp/inception/recommendation/tasks/TrainingTask.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/service/RelationSuggestionVisibilityCalculationTest.java
%	inception/inception-recommendation/src/test/java/de/tudarmstadt/ukp/inception/recommendation/service/SpanSuggestionVisibilityCalculationTest.java
%	inception/inception-remote/src/main/java/de/tudarmstadt/ukp/clarin/webanno/webapp/remoteapi/webhooks/WebhookService.java
%	inception/inception-schema/src/main/java/de/tudarmstadt/ukp/inception/schema/service/AnnotationSchemaServiceImpl.java
%	inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/SpringAuthenticatedWebSession.java
%	inception/inception-security/src/main/java/de/tudarmstadt/ukp/clarin/webanno/security/model/User.java
%	inception/inception-support/src/main/java/de/tudarmstadt/ukp/inception/support/PersistentEnumIntegerUserType.java
%	inception/inception-support/src/main/java/de/tudarmstadt/ukp/inception/support/spring/DatabaseInfoService.java
%	inception/inception-support/src/main/java/de/tudarmstadt/ukp/inception/support/svelte/SvelteBehavior.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/AnnotationPageMenuItem.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/config/AnnotationUIAutoConfiguration.java
%	inception/inception-ui-annotation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/annotation/detail/AnnotationDetailEditorPanel.java
%	inception/inception-ui-core/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/core/logout/LogoutPanel.java
%	inception/inception-ui-curation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/curation/config/CurationUIAutoConfiguration.java
%	inception/inception-ui-curation/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/curation/page/CurationPageMenuItem.java
%	inception/inception-ui-dashboard-activity/src/main/java/de/tudarmstadt/ukp/inception/ui/core/dashboard/activity/ActivitiesDashletControllerImpl.java
%	inception/inception-ui-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/project/layers/ProjectLayersPanel.java
%	inception/inception-websocket/pom.xml
%	inception/inception-websocket/src/test/java/de/tudarmstadt/ukp/inception/websocket/WebSocketIntegrationTest.java
%	pom.xml
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart