Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewport tracking does not work well in RecogitoJS editor #4310

Closed
reckart opened this issue Nov 17, 2023 · 0 comments
Closed

Viewport tracking does not work well in RecogitoJS editor #4310

reckart opened this issue Nov 17, 2023 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Recogito
Milestone
30.0

Comments

@reckart
Copy link
Member

reckart commented Nov 17, 2023

Describe the bug
Viewport tracking does not work well in RecogitoJS editor. The editor adds an svg element at the end of the wrapper which causes problems during tracking because it cause the entire document range from the first visible document until the end of the document instead of until the end of the viewport.

Expected behavior
Only the visible range should be requested.

Please complete the following information:

  • Version and build ID: 30.0-SNAPSHOT
@reckart reckart added 🐛Bug Something isn't working Module: Recogito labels Nov 17, 2023
@reckart reckart added this to the 30.0 milestone Nov 17, 2023
@reckart reckart self-assigned this Nov 17, 2023
reckart added a commit that referenced this issue Nov 17, 2023
@reckart
#4310 - Viewport tracking does not work well in RecogitoJS editor
f21bd80 
- Allow providing a CSS selector for elements to be ignored to the viewport tracker
- Ignore the SVG element injected by RecogitoJS
reckart added a commit that referenced this issue Nov 17, 2023
@reckart
Merge pull request #4311 from inception-project/bugfix/4310-Viewport-…
9ac91dd 
…tracking-does-not-work-well-in-RecogitoJS-editor

#4310 - Viewport tracking does not work well in RecogitoJS editor
@reckart reckart closed this as completed Nov 17, 2023
reckart added a commit that referenced this issue Nov 18, 2023
@reckart
Merge branch 'main' into feature/4292-ollama-based-recommender
580b9dd 
* main:
  #4308 - Support for custom XML formats
  #4308 - Support for custom XML formats
  #4310 - Viewport tracking does not work well in RecogitoJS editor
reckart added a commit that referenced this issue Nov 21, 2023
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
d8b115f 
* main: (68 commits)
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4314 - Move project API to own module
  #4308 - Support for custom XML formats
  #4308 - Support for custom XML formats
  #4308 - Support for custom XML formats
  #4310 - Viewport tracking does not work well in RecogitoJS editor
  #4308 - Support for custom XML formats
  #4302 - Files imported as HTML do not show properly in HTML-based editor
  #4305 - New predictions message is shown even if no new predictions were generated
  #4304 - Log more startup messages through boot logger
  #4229 - Better project template selection
  #4298 - Recommender status says "Waiting for evaluation" for recommenders that cannot be evaluated
  #4297 - Popover always showing "tag not in tagset" even if feature has no tagset at all
  #4294 - Infer paragraph boundaries when displaying plain text files in HTML-based editors
  #4150 - Upgrade dependencies
  ...
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recogito
Projects
Kanban
Archived in project
Milestone
30.0
Development

No branches or pull requests
1 participant
@reckart