Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow opening URL feature values in new browser window #3728

Closed
letailli opened this issue Jan 17, 2023 · 4 comments
Closed

Allow opening URL feature values in new browser window #3728

letailli opened this issue Jan 17, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@letailli
Copy link

Is your feature request related to a problem? Please describe.
We use document metadata to store the URLs from which the documents we annotate originate. The problem is that these URLs appear as a string (we use the "Primitive:String" feature type) and it's not convenient to open the link: users have to copy the link, open a new tab, paste.

Describe the solution you'd like
Add a feature type "URL" that would enable to open the link in a new tab. This would be close to the feature "Image URL" behavior.

Additional context
This demand comes from @rbossy (@Bibliome) with whom I'm currently working.

@reckart
Copy link
Member

reckart commented Jan 17, 2023

How about we enhance the existing string feature to auto-detect if a feature value is a valid URL and if so display a button to open that URL in a new window?

That would only happen if no tagset is associated with the feature (i.e. the feature editor is only a simple input field).

Would that work for you?

@reckart reckart added this to the ⭐️ Feature backlog milestone Jan 17, 2023
@rbossy
Copy link

rbossy commented Jan 18, 2023

That would be both pretty and useful.

I suppose that this would not cover properties bound to a KB. Those URIs aren't always dereferenceable.

@reckart
Copy link
Member

reckart commented Jan 18, 2023

When you link to a KB, a concept-feature-editor is used. The single-value concept-feature-editor already has a button to open the IRI in a new tab (which may fail if the IRI is not resolvable).

@reckart reckart self-assigned this Jan 29, 2023
@reckart reckart modified the milestones: ⭐️ Feature backlog, 27.0 Jan 29, 2023
@reckart reckart changed the title Add a feature type "URL" to open link easily Allow opening URL feature values in new browser window Jan 29, 2023
reckart added a commit that referenced this issue Jan 29, 2023
- If a string feature value in a single-value string feature editor without a tagset is a valid URL (http or https), a button appears to open that URL in a new window
- Also apply this design to the concept feature editor
reckart added a commit that referenced this issue Jan 29, 2023
…ening-URL-feature-values-in-new-browser-window

#3728 - Allow opening URL feature values in new browser window
@reckart reckart closed this as completed Jan 29, 2023
@reckart
Copy link
Member

reckart commented Feb 28, 2023

@rbossy @letailli If you have not already tried this feature in SNAPSHOT or beta versions, there is now a release candidate available containing this feature so you can test it: https://github.com/inception-project/inception/releases/tag/inception-27.0-rc-1

@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants