Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

annotation.default-preferences.page-size is ignored even if defined in settings.properties #3705

Closed
GiantEnemyCrab opened this issue Jan 9, 2023 · 0 comments
Closed

annotation.default-preferences.page-size is ignored even if defined in settings.properties #3705

GiantEnemyCrab opened this issue Jan 9, 2023 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Annotation
Milestone
26.6

Comments

@GiantEnemyCrab
Copy link
Contributor

Describe the bug
Even if annotation.default-preferences.page-size is explicitly set in settings.properties, this seems to not take effect, and defaults to 10.

To Reproduce
Steps to reproduce the behavior:

  1. Version 26.5 can reproduce this issue
  2. In settings.properties, set something like annotation.default-preferences.page-size=500
  3. Create a new project
  4. Import a file that would have more than 10 lines of text
  5. Open for annotation and it will only show 10 lines.

Expected behavior
annotation.default-preferences.page-size settings should take place.

Screenshots
Project settings do show that it was set to 500
image

But going into annotations, somehow it is 10, and this is the initial opening of the annotation settings windows, and this was not edited or anything to 10. The expected behavior is to see 500.
image

Please complete the following information:

  • Version and build ID: 26.5 (2023-01-06 00:12:44, build 2adb894)
  • OS: Windows
  • Browser: Chrome
@reckart reckart added this to the 26.6 milestone Jan 9, 2023
@reckart reckart added 🐛Bug Something isn't working Module: Annotation labels Jan 9, 2023
@reckart reckart self-assigned this Jan 9, 2023
reckart added a commit that referenced this issue Jan 9, 2023
@reckart
#3705 - annotation.default-preferences.page-size is ignored even if d…
8c03b51 
…efined in settings.properties

- Funnel page size property into the legacy bridge class that still fills in the legacy annotation editor preferences
reckart added a commit that referenced this issue Jan 10, 2023
@reckart
Merge pull request #3710 from inception-project/bugfix/3705-annotatio…
1c5e7f0 
…n.default-preferences.page-size-is-ignored-even-if-defined-in-settings.properties

#3705 - annotation.default-preferences.page-size is ignored even if defined in settings.properties
@reckart reckart closed this as completed Jan 10, 2023
reckart added a commit that referenced this issue Jan 10, 2023
@reckart
Merge branch 'release/26.x'
9e5496b 
* release/26.x:
  #3706 - Update dependencies (26.6)
  #3705 - annotation.default-preferences.page-size is ignored even if defined in settings.properties
  #3708 - Concept feature editor layout broken
  #3706 - Update dependencies (26.6)
  #3706 - Update dependencies (26.6)
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Annotation
Projects
Kanban
Archived in project
Milestone
26.6
Development

No branches or pull requests
2 participants
@GiantEnemyCrab @reckart