Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce exceptions thrown to reduce log pollution #2356

Open
3 of 10 tasks
jcklie opened this issue Jun 9, 2021 · 0 comments
Open
3 of 10 tasks

Reduce exceptions thrown to reduce log pollution #2356

jcklie opened this issue Jun 9, 2021 · 0 comments
Assignees
@reckart
Labels
⚙️ Refactoring
Milestone
⚙️ Maintenance ba...

Comments

@jcklie
Copy link
Contributor

jcklie commented Jun 9, 2021 •
edited by reckart
Loading

Describe the refactoring action
Some things throw exceptions but they should just log a warning/error

  • Validation failed message when finishing a document (in 22.0)
  • Actions performed through context menu
  • [PERSON] is not in the tag list. Please choose from the existing tags
  • Number of sentences [162451] exceeds limit [20000].
  • ZIP file is not a WebAnno project archive
  • Invalid ZIP file
  • No relation annotation allowed on layer [Chunk]
  • Cannot create another annotation of layer [evidence] at this location - no overlap or stacking is allowed for this layer.: Cannot create another annotation of layer [evidence] at this location - no overlap or stacking is allowed for this layer.
  • de.tudarmstadt.ukp.inception.search.ExecutionException: Unable to parse query ["<Named_entity.value=”HOUSE”/>"]
  • Cannot create relation between spans on different layers

Expected benefit
Less noise in the log, streamlining that exceptions are actual errors in INCEpTION and not caused by user errors
@jcklie jcklie added the ⭐️ Enhancement New feature or request label Jun 9, 2021
@jcklie jcklie added this to the 0.21.0 milestone Jun 9, 2021
@jcklie jcklie changed the title Reduce exceptions thrown to remove log pollution Reduce exceptions thrown to reduce log pollution Jun 9, 2021
@jcklie jcklie mentioned this issue Jun 10, 2021
Closed
@reckart reckart modified the milestones: 21.0, 22.0 Sep 7, 2021
@reckart reckart modified the milestones: 22.0, 23.0 Nov 30, 2021
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
10097d8 
- Introduce ValidationException
- Handle ValidationException when finishing document properly by displaying to the user but not logging as an exception
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
935b541 
- Select the first invalid annotation so the user can immediately fix it
- Fix small issue from the previous commit that document was closed even when invalid
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
2669f0a 
- When the user tries to finish a document, first check if finishing is possible, then open the confirmation dialog (if finishing is possible)
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
Merge pull request #2807 from inception-project/feature/2356-Reduce-e…
e0abad9 
…xceptions-thrown-to-reduce-log-pollution

#2356 - Reduce exceptions thrown to reduce log pollution
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
Merge branch 'release/22.x'
b2d645b 
* release/22.x:
  #2801 - Change label for guest account "I already have an account"
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2805 - Oversized span returned by AnnotatorJS
  #2735 - Document websocket reverse proxy config
  #2735 - Document websocket reverse proxy config
reckart added a commit that referenced this issue Jan 7, 2022
@reckart
Merge branch 'main' into refactoring/2798-Define-own-compact-wire-for…
e48a6b9 
…mat-for-annotation-transport-to-browsers

* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-22.0
  No issue. Try avoiding issue that CSRF settings bean is not found during startup.
  No issue. Try avoiding issue that CSRF settings bean is not found during startup.
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-22.0
  No issue. Fix semver calculation script.
  #2801 - Change label for guest account "I already have an account"
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2805 - Oversized span returned by AnnotatorJS
  #2735 - Document websocket reverse proxy config
  #2735 - Document websocket reverse proxy config
  #2803 - invitation link behind reverse proxy
@reckart reckart modified the milestones: 23.0, 24.0 Feb 20, 2022
@reckart reckart modified the milestones: 24.0, ⭐️ Feature backlog Apr 15, 2022
reckart added a commit that referenced this issue Oct 5, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
817c9a8 
- Do not log exceptions for common errors during context menu actions
reckart added a commit that referenced this issue Oct 5, 2022
@reckart
Merge pull request #3423 from inception-project/feature/2356-Reduce-e…
27c53a8 
…xceptions-thrown-to-reduce-log-pollution

#2356 - Reduce exceptions thrown to reduce log pollution
@reckart reckart self-assigned this Dec 4, 2022
reckart added a commit that referenced this issue Dec 4, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
4423636 
- IllegalArgumentException when trying to use an out-of-tagset tag in a string feature using a closed tagset changed to IllegalFeatureValueException
- Pull duplicate code for creating missing tags out of StringFeatureSupport and MultiValueStringFeature into the schema service
- Moved IllegalFeatureValueException to schema api module so we can use it in the schema service
@reckart reckart added ⚙️ Refactoring and removed ⭐️ Enhancement New feature or request labels Dec 4, 2022
reckart added a commit that referenced this issue Dec 4, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
dfa1157 
- Adjust tests to accomodate the moved code
reckart added a commit that referenced this issue Dec 4, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
8ac48aa 
- Suppress warning
reckart added a commit that referenced this issue Dec 4, 2022
@reckart
#2356 - Reduce exceptions thrown to reduce log pollution
6a71da8 
- Use WicketExceptionUtil in DocumentMetadataSidebar to avoid spamming log with errors on common exceptions
reckart added a commit that referenced this issue Dec 5, 2022
@reckart
Merge pull request #3613 from inception-project/feature/2356-Reduce-e…
cabd02a 
…xceptions-thrown-to-reduce-log-pollution

#2356 - Reduce exceptions thrown to reduce log pollution
reckart added a commit that referenced this issue Dec 5, 2022
@reckart
Merge branch 'release/26.x'
7d95b7c 
* release/26.x:
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
reckart added a commit that referenced this issue Dec 5, 2022
@reckart
Merge branch 'main' into feature/3606-Support-for-SAML2-IdPs
a38596a 
* main:
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #2356 - Reduce exceptions thrown to reduce log pollution
  #3602 - Enable Spring MVC CSP
  #2356 - Reduce exceptions thrown to reduce log pollution
  #3602 - Enable Spring MVC CSP
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🔖 To do in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
⚙️ Refactoring
Projects
Kanban
Status: 🔖 To do
Milestone
⚙️ Maintenance backlog
Development

No branches or pull requests
2 participants
@jcklie @reckart