Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager tabbed browsing on projects page can lead to IOOBE #1668

Closed
mbugert opened this issue Apr 16, 2020 · 0 comments
Closed

Eager tabbed browsing on projects page can lead to IOOBE #1668

mbugert opened this issue Apr 16, 2020 · 0 comments
Assignees
@reckart
Labels
🐛 Bug Something isn't working Module: Dashboard
Milestone
0.16.0

Comments

@mbugert
Copy link
Contributor

mbugert commented Apr 16, 2020

Describe the bug
On the projects.html page, the addressing scheme of projects in the list seems to be int-based. If the list changes because of external influences (for example tabbed browsing), the link targets shift around which sends users to the wrong project or in the worst case, causes an IOOBE.

To Reproduce
Steps to reproduce the behavior:

  1. Create new project called ZZZ A
  2. Create new project called ZZZ B
  3. Open projects.html page, observe both projects are there.
  4. Ctrl+Click on ZZZ A to open the dashboard for this project in a new tab. Delete the project.
  5. In the first tab with projects.html, click on ZZZ B. The page that opens is either the dashboard of the project below ZZZ B in the list or an exception page if ZZZ B was the last item in the list.

Expected behavior
Clicking on a project with name X always leads to the dashboard of project X.

Please complete the following information:

  • Version and build ID: 0.16.0-SNAPSHOT (2020-04-14 23:11:04, build fd1e338)
  • OS: Ubuntu 19.10
  • Browser: FF 75.0
@reckart reckart added the 🐛 Bug Something isn't working label Apr 28, 2020
@reckart reckart added this to the Bug backlog milestone Apr 28, 2020
@reckart reckart modified the milestones: Bug backlog, 0.15.3 Apr 28, 2020
@reckart reckart self-assigned this Apr 28, 2020
reckart added a commit that referenced this issue Apr 28, 2020
@reckart
#1668 - Eager tabbed browsing on projects page can lead to IOOBE
e4ea4c8 
- Use BookmarkablePageLinks in the project overview
- Allow the ProjectDashboardPage to take a project ID as parameter
- Unmount "welcome.html" thus making the ProjectDashboardPage reachable at the application root
@reckart reckart mentioned this issue May 5, 2020
Closed
UWinch added a commit that referenced this issue May 6, 2020
@UWinch
#1668 - Eager tabbed browsing on projects page can lead to IOOBE
d82cd57 
- tutorial bug workaround
UWinch added a commit that referenced this issue May 6, 2020
@UWinch
#1668 - Eager tabbed browsing on projects page can lead to IOOBE
8694475 
- order setting tabs
@reckart reckart closed this as completed May 12, 2020
@reckart reckart modified the milestones: 0.15.3, 0.16.0 May 12, 2020
UWinch added a commit that referenced this issue May 15, 2020
@UWinch
Merge pull request #1676 from inception-project/bugfix/1668-Eager-tab…
c42946e 
…bed-browsing-on-projects-page-can-lead-to-IOOBE

#1668 - Eager tabbed browsing on projects page can lead to IOOBE
reckart added a commit that referenced this issue May 17, 2020
@reckart
Merge branch 'master' into feature/1697-Adjust-to-upstream-changes---…
cf1bfd4 
…Better-CAS-management

* master:
  No issue. Fix illegal access warning.
  No issue. Do not commit JFR logs to repository
  #1695 - Update documentation for deployment via systemd
  #1698 - Unable to enable LAPPS recommender
  #1695 - Update documentation for deployment via systemd
  #1668 - Eager tabbed browsing on projects page can lead to IOOBE
  #1668 - Eager tabbed browsing on projects page can lead to IOOBE
  #1662 - Impossible to create annotations via Search
  #1688 - Upgrade dependencies (0.16.0)
  #1654 - NPE on session destruction
  #1668 - Eager tabbed browsing on projects page can lead to IOOBE

% Conflicts:
%	inception-curation/src/main/java/de/tudarmstadt/ukp/inception/curation/sidebar/CurationSidebar.java
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1668 - Upgrade dependencies
a3596da 
- Upgrade DKPro Parent POM 23 -> 24
- Upgrade uimaFIT 2.4.0 -> 2.5.0
- Upgrade Spring 5.1.9 -> 5.1.15
- Upgrade Spring Security 4.2.13 -> 4.2.15
- Upgrade Tomcat 8.5.51 -> 8.5.54
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1670 from webanno/feature/1668-Upgrade-dependencies
e182351 
#1668 - Upgrade dependencies
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch '3.6.x' into feature/1665-Replace-XML-based-Spring-Secur…
0cd2bf7 
…ity-config-with-Java-config-based

* 3.6.x:
  #1668 - Upgrade dependencies
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch '3.6.x'
f4151ca 
* 3.6.x:
  #1668 - Upgrade dependencies

% Conflicts:
%	pom.xml
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1668 - Upgrade dependencies (3.6.6)
d24fc22 
- Tomcat 8.5.54 -> 8.5.55
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1706 from webanno/feature/1668-Upgrade-dependencies
57dc74a 
#1668 - Upgrade dependencies (3.6.6)
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch '3.6.x'
1cf89a3 
* 3.6.x:
  #1668 - Upgrade dependencies (3.6.6)

% Conflicts:
%	pom.xml
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch 'master' into feature/1703-Improve-brat-rendering
3fdd3b0 
* master:
  #1707 - Layout for relations not having a label is broken
  #1668 - Upgrade dependencies (3.6.6)
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
#1668 - Upgrade dependencies (3.6.6)
f763c9b 
- mysql-driver 8.0.15 -> 8.0.20
- commons-beanutils 1.9.3 -> 1.9.4
- commons-collections4 4.3 -> 4.4
- commons-csv 1.6 -> 1.8
- dom4j 2.1.1 -> 2.1.3
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge pull request #1733 from webanno/feature/1668-Upgrade-dependencies
ed4624d 
#1668 - Upgrade dependencies (3.6.6)
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch '3.6.x'
3b461aa 
* 3.6.x:
  #1668 - Upgrade dependencies (3.6.6)

# Conflicts:
#	pom.xml
jcklie pushed a commit that referenced this issue Feb 2, 2021
@reckart
Merge branch 'master' into feature/1755-Support-definition-of-constra…
10ee718 
…ints-across-slot-features

* master:
  #1668 - Upgrade dependencies (3.6.6)

# Conflicts:
#	pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Dashboard
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
2 participants
@reckart @mbugert