Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No recommendations if document title doesn't match file name #1208

Closed
reckart opened this issue May 27, 2019 · 1 comment
Closed

No recommendations if document title doesn't match file name #1208

reckart opened this issue May 27, 2019 · 1 comment
Assignees
@reckart
Labels
🐛 Bug Something isn't working Module: Recommender Requires upstream changes
Milestone
0.10.0

Comments

@reckart
Copy link
Member

reckart commented May 27, 2019

Describe the bug
When a reader is used which sets the document title in the DocumentMetadata annotation to a value which does not match the filename/documentId, then no recommendations are displayed.

To Reproduce
Steps to reproduce the behavior:

  1. Import a TEI file which contains a <title> element
  2. Configure a string matching recommender
  3. Annotate a word that appears twice in the text
  4. Observe no annotation is displayed
  5. Activate active learning and see that it actually jumps to a recommendation

Expected behavior
Recommendations should be visible

Please complete the following information:
@reckart reckart self-assigned this May 27, 2019
@reckart reckart added this to the 0.10.0 milestone May 27, 2019
@reckart
Copy link
Member Author

reckart commented May 27, 2019

Requires webanno/webanno#1319 to access the sourceDocumentId from CasMetadata.

reckart added a commit that referenced this issue May 27, 2019
@reckart
#1208 - No recommendations if document title doesn't match file name
2287f6e 
- Obtain the document ID from the CasMetadata
reckart added a commit that referenced this issue May 27, 2019
@reckart
Merge pull request #1210 from inception-project/feature/1208-No-recom…
6d85aeb 
…mendations-if-document-title-does-not-match-file-name

#1208 - No recommendations if document title doesn't match file name
@reckart reckart closed this as completed May 27, 2019
reckart added a commit that referenced this issue May 28, 2019
@reckart
Merge branch 'master' into 0.10.x-uimav3
71c228f 
* master:
  #1208 - No recommendations if document title doesn't match file name
  #1198 - Fix filename of the MySQL client conf
  #780 - Wicket `@SpringBean` injection generates illegal access warning
  #1201 - Support reading TEI format
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-app-0.9.1
  #1185 - Can't export Weblicht TCF
  #1173 - Exception when linked entity spans lines
  #1191 - Fix link to docker compose
  #780 Wicket `@SpringBean` injection generates illegal access warning
  #1187 - Upgrade dependencies
  #1191 - Fix link to docker compose
  #1173 - Exception when linked entity spans lines
  #780 Wicket `@SpringBean` injection generates illegal access warning on recent JDKs
  #1176 - Add NIF import/export

% Conflicts:
%	inception-app-webapp/src/main/java/de/tudarmstadt/ukp/inception/formats/ConllUFormatSupport.java
%	pom.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛 Bug Something isn't working Module: Recommender Requires upstream changes
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
1 participant
@reckart