Skip to content

Commit

Permalink
Merge branch 'master' into feature/1472-Upgrade-dependencies
Browse files Browse the repository at this point in the history
* master:
  #1811 - Webanno does not boot in Intellij due to javax errors
  #1811 - Webanno does not boot in Intellij due to javax errors
  #1811 - Webanno does not boot in Intellij due to javax errors
  #1811 - Webanno does not boot in Intellij due to javax errors
  #1811 - Webanno does not boot in Intellij due to javax errors
  #1806 - Display incoming and outgoing relations in the details panel
  No issue: Ignore .gradle folder
  #1811 - Webanno does not boot in Intellij due to javax errors

% Conflicts:
%	pom.xml
  • Loading branch information
reckart committed Nov 25, 2020
2 parents 2402297 + ec69568 commit d82bc77
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 27 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ webanno-doc/src/main/resources/public
.checkstyle
log4j2-dev.xml
.factorypath
.gradle
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
<wicket.version>9.2.0</wicket.version>
<wicketstuff.version>9.2.0</wicketstuff.version>
<wicket-jquery-ui.version>9.1.0</wicket-jquery-ui.version>
<wicket-bootstrap.version>5.0.2</wicket-bootstrap.version>
<wicket-bootstrap.version>5.0.3</wicket-bootstrap.version>
<wicket-jquery-selectors.version>3.0.1</wicket-jquery-selectors.version>
<wicket-webjars.version>3.0.1</wicket-webjars.version>
<wicket-spring-boot.version>3.0.4</wicket-spring-boot.version>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1211,6 +1211,10 @@ public List<AttachedAnnotation> getAttachedRels(AnnotationLayer aLayer, Annotati
}

for (AnnotationFS relationFS : CasUtil.select(cas, relationType)) {
if (!(relationFS instanceof AnnotationFS)) {
continue;
}

// Here we get the annotations that the relation is pointing to in the UI
AnnotationFS sourceFS;
if (relationSourceAttachFeature != null) {
Expand Down Expand Up @@ -1265,6 +1269,10 @@ public List<AttachedAnnotation> getAttachedLinks(AnnotationLayer aLayer, Annotat
// them actually links to the current FS
Type linkHost = CasUtil.getType(cas, linkFeature.getLayer().getName());
for (FeatureStructure linkFS : CasUtil.selectFS(cas, linkHost)) {
if (!(linkFS instanceof AnnotationFS)) {
continue;
}

List<LinkWithRoleModel> links = adapter.getFeatureValue(linkFeature,
linkFS);
for (int li = 0; li < links.size(); li++) {
Expand Down
19 changes: 3 additions & 16 deletions webanno-webapp/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -251,21 +251,6 @@
</exclusion>
</exclusions>
</dependency>
<dependency>
<groupId>jakarta.validation</groupId>
<artifactId>jakarta.validation-api</artifactId>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.tomcat.embed</groupId>
<artifactId>tomcat-embed-core</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-tomcat</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-autoconfigure</artifactId>
Expand Down Expand Up @@ -435,6 +420,9 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<ignoredUsedUndeclaredDependencies>
<ignoredUsedUndeclaredDependency>org.apache.tomcat.embed:tomcat-embed-core</ignoredUsedUndeclaredDependency>
</ignoredUsedUndeclaredDependencies>
<usedDependencies combine.children="append">
<!-- WebAnno UI Modules - they auto-register via reflection -->
<usedDependency>de.tudarmstadt.ukp.clarin.webanno:webanno-ui-annotation</usedDependency>
Expand Down Expand Up @@ -472,7 +460,6 @@
<usedDependency>com.googlecode.wicket-jquery-ui:wicket-jquery-ui-theme-uilightness</usedDependency>
<!-- Spring Boot stuff - used via reflection/classpath -->
<usedDependency>org.springframework:spring-webmvc</usedDependency>
<usedDependency>org.springframework.boot:spring-boot-starter-tomcat</usedDependency>
<usedDependency>org.springframework.boot:spring-boot-starter-web</usedDependency>
<usedDependency>com.giffing.wicket.spring.boot.starter:wicket-spring-boot-starter</usedDependency>
<usedDependency>org.springframework.boot:spring-boot-starter-validation</usedDependency>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
import java.util.Optional;

import javax.swing.JWindow;
import javax.validation.Validator;

import org.apache.catalina.connector.Connector;
import org.apache.uima.cas.impl.CASImpl;
Expand All @@ -36,13 +35,11 @@
import org.springframework.boot.web.embedded.tomcat.TomcatServletWebServerFactory;
import org.springframework.boot.web.servlet.support.SpringBootServletInitializer;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Primary;
import org.springframework.scheduling.annotation.EnableAsync;
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
import org.springframework.security.crypto.password.DelegatingPasswordEncoder;
import org.springframework.security.crypto.password.PasswordEncoder;
import org.springframework.security.crypto.password.StandardPasswordEncoder;
import org.springframework.validation.beanvalidation.LocalValidatorFactoryBean;

import de.tudarmstadt.ukp.clarin.webanno.plugin.api.PluginManager;
import de.tudarmstadt.ukp.clarin.webanno.plugin.impl.PluginManagerImpl;
Expand Down Expand Up @@ -75,13 +72,6 @@ public class WebAnno
@Value("${server.ajp.address:127.0.0.1}")
private String ajpAddress;

@Bean
@Primary
public Validator validator()
{
return new LocalValidatorFactoryBean();
}

@Bean
public PluginManager pluginManager()
{
Expand Down

0 comments on commit d82bc77

Please sign in to comment.