#5149 - Page hangs when listing LLM models is not possible

- Set a 10 second timeout for model listing calls
inception-project · Nov 6, 2024 · 9d4a8ad · 9d4a8ad
1 parent f45d19f
commit 9d4a8ad
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/...va/de/tudarmstadt/ukp/inception/recommendation/imls/chatgpt/client/ChatGptClientImpl.java b/...va/de/tudarmstadt/ukp/inception/recommendation/imls/chatgpt/client/ChatGptClientImpl.java
@@ -29,6 +29,7 @@
 import java.net.http.HttpRequest;
 import java.net.http.HttpRequest.BodyPublishers;
 import java.net.http.HttpResponse;
+import java.time.Duration;
 import java.util.Comparator;
 import java.util.List;
 import java.util.Map;
@@ -141,6 +142,7 @@ public List<ChatGptModel> listModels(String aUrl, ListModelsRequest aRequest) th
                 .uri(URI.create(appendIfMissing(aUrl, "/") + "models")) //
                 .header(HttpHeaders.CONTENT_TYPE, "application/json").GET() //
                 .header("Authorization", "Bearer " + aRequest.getApiKey()) //
+                .timeout(Duration.ofSeconds(10)) //
                 .build();
 
         var response = sendRequest(request);

diff --git a/...main/java/de/tudarmstadt/ukp/inception/recommendation/imls/hf/client/HfHubClientImpl.java b/...main/java/de/tudarmstadt/ukp/inception/recommendation/imls/hf/client/HfHubClientImpl.java
@@ -24,6 +24,7 @@
 import java.net.http.HttpClient;
 import java.net.http.HttpRequest;
 import java.net.http.HttpResponse;
+import java.time.Duration;
 import java.util.LinkedHashMap;
 import java.util.Map;
 
@@ -82,6 +83,7 @@ public HfModelCard[] queryCatalog(Map<String, String> aQueryParameters) throws I
 
         HttpRequest request = HttpRequest.newBuilder() //
                 .uri(URI.create(uriBuilder.toString())) //
+                .timeout(Duration.ofSeconds(10)) //
                 .build();
 
         HttpResponse<String> response = sendRequest(request);

diff --git a/...java/de/tudarmstadt/ukp/inception/recommendation/imls/ollama/client/OllamaClientImpl.java b/...java/de/tudarmstadt/ukp/inception/recommendation/imls/ollama/client/OllamaClientImpl.java
@@ -30,6 +30,7 @@
 import java.net.http.HttpRequest.BodyPublishers;
 import java.net.http.HttpResponse;
 import java.nio.charset.StandardCharsets;
+import java.time.Duration;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
@@ -142,6 +143,7 @@ public List<OllamaModel> listModels(String aUrl) throws IOException
         var request = HttpRequest.newBuilder() //
                 .uri(URI.create(appendIfMissing(aUrl, "/") + "api/tags")) //
                 .header(HttpHeaders.CONTENT_TYPE, "application/json").GET() //
+                .timeout(Duration.ofSeconds(10)) //
                 .build();
 
         var response = sendRequest(request);