Merge pull request #4299 from inception-project/bugfix/4297-Popover-a…

…lways-showing-tag-not-in-tagset-even-if-feature-has-no-tagset-at-all #4297 - Popover always showing "tag not in tagset" even if feature has no tagset at all
inception-project · Nov 14, 2023 · 7ebc198 · 7ebc198
2 parents 3bd1a8c + 56bf4aa
commit 7ebc198
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...armstadt/ukp/inception/annotation/feature/multistring/MultiValueStringFeatureSupport.java b/...armstadt/ukp/inception/annotation/feature/multistring/MultiValueStringFeatureSupport.java
@@ -242,7 +242,7 @@ public List<VLazyDetailGroup> lookupLazyDetails(AnnotationFeature aFeature, Obje
                     var value = (String) v;
                     var tag = schemaService.getTag(value, aFeature.getTagset());
 
-                    if (tag.isEmpty()) {
+                    if (aFeature.getTagset() != null && tag.isEmpty()) {
                         results.addDetail(new VLazyDetail(value, "Tag not in tagset"));
                     }
 

diff --git a/...ain/java/de/tudarmstadt/ukp/inception/annotation/feature/string/StringFeatureSupport.java b/...ain/java/de/tudarmstadt/ukp/inception/annotation/feature/string/StringFeatureSupport.java
@@ -236,7 +236,7 @@ public List<VLazyDetailGroup> lookupLazyDetails(AnnotationFeature aFeature, Obje
         if (aValue instanceof String) {
             var value = (String) aValue;
             var tag = schemaService.getTag(value, aFeature.getTagset());
-            if (tag.isEmpty()) {
+            if (aFeature.getTagset() != null && tag.isEmpty()) {
                 return asList(new VLazyDetailGroup(new VLazyDetail(value, "Tag not in tagset")));
             }