#3610 - Minimizing icon in document level feature is wrong after upda…

…ting feature - Fix visibility condition
inception-project · Jan 4, 2023 · 6fc2ae9 · 6fc2ae9
1 parent 797485f
commit 6fc2ae9
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/...stadt/ukp/inception/ui/core/docanno/sidebar/DocumentMetadataAnnotationSelectionPanel.java b/...stadt/ukp/inception/ui/core/docanno/sidebar/DocumentMetadataAnnotationSelectionPanel.java
@@ -296,8 +296,7 @@ protected void onEvent(AjaxRequestTarget aTarget)
                     }
                 });
 
-                detailPanel.add(visibleWhen(
-                        () -> selectedAnnotation == container || aItem.getModelObject().singleton));
+                detailPanel.add(visibleWhen(() -> isExpanded(aItem, container)));
 
                 if (createdAnnotationAddress == vid.getId()) {
                     createdAnnotationAddress = -1;
@@ -306,14 +305,12 @@ protected void onEvent(AjaxRequestTarget aTarget)
                 }
 
                 WebMarkupContainer close = new WebMarkupContainer("close");
-                close.add(visibleWhen(
-                        () -> !detailPanel.isVisible() && !aItem.getModelObject().singleton));
+                close.add(visibleWhen(() -> isExpanded(aItem, container)));
                 close.setOutputMarkupId(true);
                 container.add(close);
 
                 WebMarkupContainer open = new WebMarkupContainer("open");
-                open.add(visibleWhen(
-                        () -> detailPanel.isVisible() && !aItem.getModelObject().singleton));
+                open.add(visibleWhen(() -> !isExpanded(aItem, container)));
                 open.setOutputMarkupId(true);
                 container.add(open);
 
@@ -332,6 +329,12 @@ protected void onEvent(AjaxRequestTarget aTarget)
 
                 aItem.setOutputMarkupId(true);
             }
+
+            private boolean isExpanded(ListItem<AnnotationListItem> aItem,
+                    WebMarkupContainer container)
+            {
+                return selectedAnnotation == container || aItem.getModelObject().singleton;
+            }
         };
     }