Merge pull request #3631 from inception-project/bugfix/3609-Feature-e…

…ditors-do-not-show-annotations-in-locked-documents-for-multilabel-String-features #3609 - Feature editors do not show annotations in locked documents for multilabel String features
inception-project · Dec 13, 2022 · 61ccff4 · 61ccff4
2 parents cabd02a + 2b7d03b
commit 61ccff4
Showing 1 changed file with 78 additions and 27 deletions.
diff --git a/...udarmstadt/ukp/inception/annotation/feature/multistring/MultiSelectTextFeatureEditor.java b/...udarmstadt/ukp/inception/annotation/feature/multistring/MultiSelectTextFeatureEditor.java
@@ -29,6 +29,7 @@
 import org.apache.wicket.markup.html.form.FormComponent;
 import org.apache.wicket.model.CompoundPropertyModel;
 import org.apache.wicket.model.IModel;
+import org.apache.wicket.model.Model;
 import org.apache.wicket.spring.injection.annot.SpringBean;
 
 import com.googlecode.wicket.jquery.core.JQueryBehavior;
@@ -51,6 +52,9 @@
 public class MultiSelectTextFeatureEditor
     extends FeatureEditor
 {
+    private static final String CID_TEXT_INDICATOR = "textIndicator";
+    private static final String CID_VALUE = "value";
+
     private static final long serialVersionUID = 7469241620229001983L;
 
     private @SpringBean AnnotationSchemaService annotationService;
@@ -61,32 +65,91 @@ public class MultiSelectTextFeatureEditor
     // // For showing the status of Constraints rules kicking in.
     // private RulesIndicator indicator = new RulesIndicator();
 
-    private final MultiSelect<ReorderableTag> field;
+    private FormComponent<?> field;
 
     public MultiSelectTextFeatureEditor(String aId, MarkupContainer aOwner,
             final IModel<FeatureState> aFeatureStateModel, AnnotationActionHandler aHandler)
     {
         super(aId, aOwner, CompoundPropertyModel.of(aFeatureStateModel));
 
-        field = new MultiSelect<ReorderableTag>("value", new ChoiceRenderer<>())
+        field = createInput();
+        add(field);
+
+        add(new ConstraintsInUseIndicator(CID_TEXT_INDICATOR, getModel()));
+    }
+
+    /**
+     * Hides feature if "Hide un-constraint feature" is enabled and constraint rules are applied and
+     * feature doesn't match any constraint rule
+     */
+    @SuppressWarnings("unchecked")
+    @Override
+    public void onConfigure()
+    {
+        super.onConfigure();
+
+        // Workaround for https://github.com/sebfz1/wicket-jquery-ui/issues/352
+        if ((isEnabledInHierarchy() && !(field instanceof MultiSelect))
+                || !isEnabledInHierarchy() && (field instanceof MultiSelect)) {
+            field = (FormComponent<ReorderableTag>) field.replaceWith(createInput());
+        }
+
+        // if enabled and constraints rule execution returns anything other than green
+        var featState = getModelObject();
+        setVisible(!featState.feature.isHideUnconstraintFeature() || //
+                (featState.indicator.isAffected()
+                        && featState.indicator.getStatusColor().equals("green")));
+    }
+
+    private FormComponent<?> createInput()
+    {
+        if (isEnabledInHierarchy()) {
+            return createEditableInput();
+        }
+        else {
+            return createReadOnlyInput();
+        }
+    }
+
+    @SuppressWarnings({ "unchecked", "rawtypes" })
+    private FormComponent<String> createReadOnlyInput()
+    {
+        var input = new com.googlecode.wicket.kendo.ui.form.multiselect. //
+                MultiSelect<String>(CID_VALUE)
+        {
+            private static final long serialVersionUID = 1L;
+
+            @Override
+            public void onConfigure(JQueryBehavior aBehavior)
+            {
+                super.onConfigure(aBehavior);
+                styleMultiSelect(aBehavior);
+            }
+        };
+        var choices = getChoices(getModel(), null).stream().map(t -> t.getName()).collect(toList());
+        input.setChoices(Model.ofList(choices));
+        return (FormComponent) input;
+    }
+
+    @SuppressWarnings({ "unchecked", "rawtypes" })
+    private FormComponent<ReorderableTag> createEditableInput()
+    {
+        return (FormComponent) new MultiSelect<ReorderableTag>(CID_VALUE, new ChoiceRenderer<>())
         {
             private static final long serialVersionUID = 7769511105678209462L;
 
             @Override
             protected List<ReorderableTag> getChoices(String aInput)
             {
-                return MultiSelectTextFeatureEditor.this.getChoices(aFeatureStateModel, aInput);
+                return MultiSelectTextFeatureEditor.this
+                        .getChoices(MultiSelectTextFeatureEditor.this.getModel(), aInput);
             }
 
             @Override
             public void onConfigure(JQueryBehavior aBehavior)
             {
                 super.onConfigure(aBehavior);
-
-                aBehavior.setOption("autoWidth", true);
-                aBehavior.setOption("animation", false);
-                aBehavior.setOption("delay", 250);
-                aBehavior.setOption("height", 300);
+                styleMultiSelect(aBehavior);
             }
 
             @Override
@@ -103,7 +166,6 @@ protected IJQueryTemplate newTemplate()
              * return strings on the way out into the model. This is a very evil hack and we need to
              * avoid declaring generic types because we work against them!
              */
-            @SuppressWarnings({ "unchecked", "rawtypes" })
             @Override
             public void convertInput()
             {
@@ -114,9 +176,14 @@ public void convertInput()
                         .collect(toList()));
             }
         };
-        add(field);
+    }
 
-        add(new ConstraintsInUseIndicator("textIndicator", getModel()));
+    private void styleMultiSelect(JQueryBehavior aBehavior)
+    {
+        aBehavior.setOption("autoWidth", true);
+        aBehavior.setOption("animation", false);
+        aBehavior.setOption("delay", 250);
+        aBehavior.setOption("height", 300);
     }
 
     @SuppressWarnings("rawtypes")
@@ -126,22 +193,6 @@ public FormComponent getFocusComponent()
         return field;
     }
 
-    /**
-     * Hides feature if "Hide un-constraint feature" is enabled and constraint rules are applied and
-     * feature doesn't match any constraint rule
-     */
-    @Override
-    public void onConfigure()
-    {
-        super.onConfigure();
-
-        // if enabled and constraints rule execution returns anything other than green
-        var featState = getModelObject();
-        setVisible(!featState.feature.isHideUnconstraintFeature() || //
-                (featState.indicator.isAffected()
-                        && featState.indicator.getStatusColor().equals("green")));
-    }
-
     private List<ReorderableTag> getChoices(final IModel<FeatureState> aFeatureStateModel,
             String aInput)
     {