#4495 - Error marker on annotations with required multi-value feature…

…s is missing

- Fix displaying validation comments in the brat editor
- Fix validation of required multi-value string/concept features

inception/inception-brat-editor/src/main/ts/src/visualizer/Visualizer.ts

@@ -1283,8 +1283,6 @@ export class Visualizer {
       this.calculateChunkTextElementMeasure(fragment, text))
   }
 
-
-
   /**
    * measure the text position in pixels
    */
@@ -1303,8 +1301,7 @@ export class Visualizer {
             collapsedSpaces++
           }
           lastCharSpace = true
-        }
-        else {
+        } else {
           lastCharSpace = false
         }
       }
@@ -3548,6 +3545,13 @@ export class Visualizer {
       fakeSpan.vid = id
       fakeSpan.document = { text: this.data.text }
       fakeSpan.layer = { id: span.type, name: Util.spanDisplayForm(this.entityTypes, span.type) }
+      if (span.comment) {
+        if (span.comment.type === 'AnnotationError') {
+          fakeSpan.comments = [{ type: 'error', comment: span.comment.text }]
+        } else {
+          fakeSpan.comments = [{ type: 'info', comment: span.comment.text }]
+        }
+      }
       evt.target.dispatchEvent(new AnnotationOverEvent(fakeSpan, evt.originalEvent))
     }
 
@@ -3713,6 +3717,13 @@ export class Visualizer {
         fakeRelation.vid = arcId
         const labelText = Util.arcDisplayForm(this.entityTypes, originSpanType, role, this.relationTypes)
         fakeRelation.layer = { id: role, name: labelText }
+        if (commentText) {
+          if (commentType === 'AnnotationError') {
+            fakeRelation.comments = [{ type: 'error', comment: commentText }]
+          } else {
+            fakeRelation.comments = [{ type: 'info', comment: commentText }]
+          }
+        }
         evt.target.dispatchEvent(new AnnotationOverEvent(fakeRelation, evt.originalEvent))
       }
 
@@ -3747,7 +3758,7 @@ export class Visualizer {
           fakeSpan.layer = { id: 0, name: Util.spanDisplayForm(this.entityTypes, comment.type) }
           evt.target.dispatchEvent(new AnnotationOverEvent(fakeSpan, evt.originalEvent))
         }
-  
+
         this.dispatcher.post('displaySentComment', [evt, comment.text, comment.type])
       }
     }
@@ -3800,7 +3811,6 @@ export class Visualizer {
 
     if (target.getAttribute('data-arc-role')) {
       this.onMouseOutArc(evt)
-      return
     }
   }
 

inception/inception-schema-api/src/main/java/de/tudarmstadt/ukp/inception/schema/api/validation/ValidationUtils.java

@@ -20,6 +20,9 @@
 import static org.apache.commons.lang3.StringUtils.isBlank;
 import static org.apache.uima.cas.CAS.TYPE_NAME_STRING;
 
+import java.util.List;
+
+import org.apache.uima.cas.CAS;
 import org.apache.uima.cas.FeatureStructure;
 import org.apache.uima.fit.util.FSUtil;
 
@@ -38,6 +41,11 @@ public static boolean isRequiredFeatureMissing(AnnotationFeature aFeature, Featu
             return isBlank(FSUtil.getFeature(aFS, aFeature.getName(), String.class));
         }
 
+        if (CAS.TYPE_NAME_STRING_ARRAY.equals(aFeature.getType())) {
+            var value = FSUtil.getFeature(aFS, aFeature.getName(), List.class);
+            return value == null || value.isEmpty();
+        }
+
         return false;
     }
 }